Add minSize option which moves small languages into other result#35
Merged
Add minSize option which moves small languages into other result#35
minSize option which moves small languages into other result#35Conversation
An implementation of a `minSize` option (proposed in #32). This allows filtering the output to only show languages with a resulting size greater than what the user inputs. This is done by moving the results of these too-small languages to an `other` key and deleting the original results. This may be too ad-hoc - for instance, maybe this should be a CLI-only option and the actual data isn't changed? Is the `other` key needed, or not? For this reason this feature is not being committed straight to main and will sit as a pull request for proposal.
Owner
Author
|
The diff is very readable if anyone interested in this feature wants to look at the methodology of doing this - https://github.com/Nixinova/LinguistJS/pull/35/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implementation of a
minSizeoption, proposed here:This allows filtering the output to only show languages with a resulting size greater than what the user inputs.
This is done by moving the results of these too-small languages to an
otherkey and deleting the original results.This may be too ad-hoc - for instance, maybe this should be a CLI-only option and the actual data isn't changed? Is the
otherkey needed, or not?For this reason this feature is not being committed straight to main and will sit as a pull request for proposal.
Feedback would be welcome on the best implementation for this feature.
Example console output with this feature implemented: