Skip to content

[staging-next] Pile of assorted fixes found while rebuilding my flake#422890

Merged
K900 merged 14 commits into
NixOS:staging-nextfrom
K900:assorted-staging-next-fixes
Jul 6, 2025
Merged

[staging-next] Pile of assorted fixes found while rebuilding my flake#422890
K900 merged 14 commits into
NixOS:staging-nextfrom
K900:assorted-staging-next-fixes

Conversation

@K900
Copy link
Copy Markdown
Contributor

@K900 K900 commented Jul 6, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Jul 6, 2025
alyssais
alyssais requested changes Jul 6, 2025
View reviewed changes
Comment thread pkgs/by-name/ni/nix-ld/package.nix Outdated
Comment thread pkgs/by-name/we/webrtc-audio-processing/package.nix Outdated
Comment thread pkgs/kde/frameworks/kimageformats/default.nix Outdated
Copy link
Copy Markdown
Member

@alyssais alyssais Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream?

Copy link
Copy Markdown
Contributor Author

@K900 K900 Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is entirely our problem, #417080.

Copy link
Copy Markdown
Member

@alyssais alyssais Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to just revert then?

Copy link
Copy Markdown
Contributor Author

@K900 K900 Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50k rebuilds says no.

Copy link
Copy Markdown
Member

@alyssais alyssais Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I missed that this is extraBuildInputs. Should we revert on staging?

@nixpkgs-ci nixpkgs-ci Bot added the 6.topic: erlang General-purpose, concurrent, functional high-level programming language label Jul 6, 2025
@K900 K900 force-pushed the assorted-staging-next-fixes branch from c7a38df to 74bd61d Compare July 6, 2025 10:43
alyssais
alyssais reviewed Jul 6, 2025
View reviewed changes
Comment thread pkgs/by-name/we/webrtc-audio-processing/package.nix Outdated
alyssais
alyssais reviewed Jul 6, 2025
View reviewed changes
Comment thread pkgs/development/python-modules/polars/default.nix Outdated
@K900 K900 force-pushed the assorted-staging-next-fixes branch from 74bd61d to c5cd10f Compare July 6, 2025 11:08
K900 added 9 commits July 6, 2025 14:14
@K900
webrtc-audio-processing: disable inline SSE on i686
26f8e78 
We don't require SSE support so things break.
@K900
jq: refresh i686 patch
01e61b7
@K900
kdePackages.kimageformats: temporarily disable libavif support
2c91b7b
@K900
python313Packages.geventhttpclient: 2.3.3 -> 2.3.4
9fc5cfc 
Diff: geventhttpclient/geventhttpclient@refs/tags/2.3.3...refs/tags/2.3.4

Changelog: https://github.com/geventhttpclient/geventhttpclient/releases/tag/2.3.4
@K900
libqalculate: remove doxygen hack
0e49a8d 
Doesn't actually work, the build system calls it correctly
@K900
python313Packages.polars: fix build with Rust 1.88.0
55b0d38
@K900
python313Packages.scikit-learn: skip tests that assert on specific wa…
b5fefec 
…rnings

Scipy update added more warnings, so these tests now fail.
Upstream has stopped using deprecated APIs, but it's not in a release yet.
@K900
rebar3: don't patchShebangs
41d70b1 
Fixes building Erlang things.
@K900
pinentry: update gettext 0.25 fixes to also apply to Linux
466cedf
@K900 K900 force-pushed the assorted-staging-next-fixes branch from c5cd10f to 466cedf Compare July 6, 2025 11:14
@K900 K900 merged commit d5e6750 into NixOS:staging-next Jul 6, 2025
23 checks passed
@K900 K900 deleted the assorted-staging-next-fixes branch July 27, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@NickCao NickCao Awaiting requested review from NickCao

Assignees

No one assigned

Labels

6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@K900 @alyssais