Skip to content

vcv-rack: 2.6.0 -> 2.6.4#411452

Closed
liberodark wants to merge 1 commit intoNixOS:masterfrom
liberodark:fix-vcv-rack
Closed

vcv-rack: 2.6.0 -> 2.6.4#411452
liberodark wants to merge 1 commit intoNixOS:masterfrom
liberodark:fix-vcv-rack

Conversation

@liberodark
Copy link
Copy Markdown
Contributor

@liberodark liberodark commented May 27, 2025

Changelog : https://github.com/VCVRack/Rack/blob/v2/CHANGELOG.md
Diff : VCVRack/Rack@v2.6.0...v2.6.4
Fix : #407443

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 27, 2025
@liberodark liberodark force-pushed the fix-vcv-rack branch 6 times, most recently from ba889ca to ba198f6 Compare May 27, 2025 16:41
@liberodark liberodark requested a review from GaetanLepage May 27, 2025 16:41
@GaetanLepage
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 411452


x86_64-linux

✅ 1 package built:
  • vcv-rack

aarch64-linux

❌ 1 package failed to build:
  • vcv-rack

@liberodark
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 411452

Logs: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/15863368113


x86_64-linux (sandbox = true)

✅ 1 package built:
  • vcv-rack

aarch64-linux (sandbox = true)

❌ 1 package failed to build:
  • vcv-rack

Error logs: `aarch64-linux`
vcv-rack
                 from src/core/Notes.cpp:1:
include/dsp/convert.hpp:17:1: warning: 'gcc_struct' attribute directive ignored [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wattributes�-Wattributes8;;�]
   17 | Int24 {
      | ^~~~~
g++ -std=c++11 -Wsuggest-override  -Iinclude -Idep/include -fPIC -fno-gnu-unique -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -march=armv8-a+fp+simd  -c -o build/src/core/plugin.cpp.o src/core/plugin.cpp
In file included from include/rack.hpp:122,
                 from src/core/plugin.hpp:1,
                 from src/core/plugin.cpp:1:
include/dsp/convert.hpp:17:1: warning: 'gcc_struct' attribute directive ignored [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wattributes�-Wattributes8;;�]
   17 | Int24 {
      | ^~~~~
g++ -std=c++11 -Wsuggest-override  -Iinclude -Idep/include -fPIC -fno-gnu-unique -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -march=armv8-a+fp+simd  -c -o build/src/dsp/minblep.cpp.o src/dsp/minblep.cpp
g++ -std=c++11 -Wsuggest-override  -Iinclude -Idep/include -fPIC -fno-gnu-unique -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -march=armv8-a+fp+simd  -c -o build/src/engine/Cable.cpp.o src/engine/Cable.cpp
g++ -std=c++11 -Wsuggest-override  -Iinclude -Idep/include -fPIC -fno-gnu-unique -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -march=armv8-a+fp+simd  -c -o build/src/engine/Engine.cpp.o src/engine/Engine.cpp
src/engine/Engine.cpp: In function 'void rack::engine::cpuPause()':
src/engine/Engine.cpp:28:9: error: '__yield' was not declared in this scope; did you mean '__ynl'?
   28 |         __yield();
      |         ^~~~~~~
      |         __ynl
make: *** [compile.mk:79: build/src/engine/Engine.cpp.o] Error 1

@liberodark
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 411452

Logs: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/16414620150


x86_64-linux

✅ 1 package built:
  • vcv-rack

aarch64-linux

❌ 1 package failed to build:
  • vcv-rack

Error logs: `aarch64-linux`
vcv-rack
                 from src/core/Notes.cpp:1:
include/dsp/convert.hpp:17:1: warning: 'gcc_struct' attribute directive ignored [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wattributes�-Wattributes8;;�]
   17 | Int24 {
      | ^~~~~
g++ -std=c++11 -Wsuggest-override  -Iinclude -Idep/include -fPIC -fno-gnu-unique -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -march=armv8-a+fp+simd  -c -o build/src/core/plugin.cpp.o src/core/plugin.cpp
In file included from include/rack.hpp:122,
                 from src/core/plugin.hpp:1,
                 from src/core/plugin.cpp:1:
include/dsp/convert.hpp:17:1: warning: 'gcc_struct' attribute directive ignored [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wattributes�-Wattributes8;;�]
   17 | Int24 {
      | ^~~~~
g++ -std=c++11 -Wsuggest-override  -Iinclude -Idep/include -fPIC -fno-gnu-unique -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -march=armv8-a+fp+simd  -c -o build/src/dsp/minblep.cpp.o src/dsp/minblep.cpp
g++ -std=c++11 -Wsuggest-override  -Iinclude -Idep/include -fPIC -fno-gnu-unique -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -march=armv8-a+fp+simd  -c -o build/src/engine/Cable.cpp.o src/engine/Cable.cpp
g++ -std=c++11 -Wsuggest-override  -Iinclude -Idep/include -fPIC -fno-gnu-unique -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -march=armv8-a+fp+simd  -c -o build/src/engine/Engine.cpp.o src/engine/Engine.cpp
src/engine/Engine.cpp: In function 'void rack::engine::cpuPause()':
src/engine/Engine.cpp:28:9: error: '__yield' was not declared in this scope; did you mean '__ynl'?
   28 |         __yield();
      |         ^~~~~~~
      |         __ynl
make: *** [compile.mk:79: build/src/engine/Engine.cpp.o] Error 1

@afh
Copy link
Copy Markdown
Member

afh commented Nov 7, 2025

Could I interest you in helping out over on #332358, @liberodark?

@liberodark
Copy link
Copy Markdown
Contributor Author

Superseed by : #332358

@liberodark liberodark closed this Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vcv-rack: package installation is broken

3 participants