nodejs_24: 24.0.0-rc.2 -> 24.0.0-rc.3#403837
Merged
FliegendeWurst merged 1 commit intoNixOS:staging-nextfrom May 3, 2025
Merged
nodejs_24: 24.0.0-rc.2 -> 24.0.0-rc.3#403837FliegendeWurst merged 1 commit intoNixOS:staging-nextfrom
FliegendeWurst merged 1 commit intoNixOS:staging-nextfrom
Conversation
Member
|
Anything OK for master is OK for staging-next, too. |
Member
|
Is there a specific reason #395431 and this PR target staging(-next)? The rebuild count is low for both PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a quite important V8 update, which would be quite important to not wait for the next staging cycle to include. FYI this RC should be promoted as the actual 24.0.0 release next Tuesday. If that does not qualify for
staging-next, I guess it can wait for #401526 to land and I'll change the base branch tomaster.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.