cargo-web: Fix build failure#345812
Merged
Merged
Conversation
ofborg
Bot
added
10.rebuild-darwin: 1-10
Member
|
Result of 1 package built:
|
Member
|
Result of 1 package built:
|
momeemt
suggested changes
Oct 2, 2024
Member
momeemt
left a comment
momeemt
left a comment
There was a problem hiding this comment.
Thank you for your contribution. I have left the comment about the patch. Also, would you format the derivation via nixfmt if possible?
myclevorname
force-pushed
the
cargo-web
branch
from
b679ef0 to
fc6e76b
Compare
myclevorname
force-pushed
the
cargo-web
branch
from
fc6e76b to
6d1b22a
Compare
Contributor
Author
|
Result of 1 package built:
|
momeemt
added
the
12.approvals: 1
kevincox
approved these changes
Oct 2, 2024
Comment on lines
+26
to
+30
| (fetchpatch { | ||
| name = "fix-qualified-path.patch"; | ||
| url = "https://github.com/koute/cargo-web/commit/c9584542163d60d0aae6d6890509794e838e257f.patch"; | ||
| hash = "sha256-w59fXmrszptKt0llqGt0AF+0b3r9N6xUY6zQkpZnemE="; | ||
| }) |
Contributor
There was a problem hiding this comment.
I'm not opposed to this fix but it make may sense to just disable warnings-as-error as clippy will keep getting more lints over time.
Contributor
|
Result of 1 package built:
|
wegank
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR I made upstream, but integrated into Nixpkgs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.