Skip to content

Bump cargo-clone version to v1.2.3#337058

Merged
alyssais merged 1 commit intoNixOS:masterfrom
JanLikar:bump-cargo-clone
Aug 24, 2024
Merged

Bump cargo-clone version to v1.2.3#337058
alyssais merged 1 commit intoNixOS:masterfrom
JanLikar:bump-cargo-clone

Conversation

@JanLikar
Copy link
Copy Markdown
Contributor

@JanLikar JanLikar commented Aug 24, 2024

Due to a breaking change in Rust compiler 1.80.0 cargo-clone cannot be built.
See #332957.

Version 1.2.3 includes a fix for this issue and several cargo-clone dependency updates.
Changelog: https://github.com/JanLikar/cargo-clone/blob/v1.2.3/CHANGELOG.md

Thanks to @eopb for resolving the upstream issue.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Copy Markdown
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the commit message conventions.

Due to a breaking change in Rust compiler 1.80.0 cargo-clone cannot be built.
See NixOS#332957.

Version 1.2.3 includes a fix for this issue and several cargo-clone dependency updates.
Changelog: https://github.com/JanLikar/cargo-clone/blob/v1.2.3/CHANGELOG.md
@ofborg ofborg Bot requested review from figsoda and matthiasbeyer August 24, 2024 18:20
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 24, 2024
@JanLikar
Copy link
Copy Markdown
Contributor Author

Ah, thank you for pointing it out. I was too eager to get it done.

@JanLikar JanLikar requested a review from alyssais August 24, 2024 18:21
@alyssais alyssais merged commit 4e2fc88 into NixOS:master Aug 24, 2024
@JanLikar JanLikar deleted the bump-cargo-clone branch August 25, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants