Allow metrics that contain colons and brackets#1572
Open
knedlsepp wants to merge 1 commit intoNixOS:masterfrom
Open
Allow metrics that contain colons and brackets#1572knedlsepp wants to merge 1 commit intoNixOS:masterfrom
knedlsepp wants to merge 1 commit intoNixOS:masterfrom
Conversation
On my personal hydra I've been using benchmarking metric names that are derived from pytest test names like `test_foo.py::test_bar[1]`. Since NixOS#1449 these metrics are rendered correctly in the metrics tab. However since commit 0d3842a these metric names are no longer supported and (silently) don't get ingested anymore. With this commit I'm relaxing the strictness of the metric name regex in order to support ingesting these metrics again.
knedlsepp
force-pushed
the
relax-hydra-metrics-name-check
branch
from
75607bd to
92f9d0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my personal hydra I've been using benchmarking metric names that are derived from pytest test names like
test_foo.py::test_bar[1]. Since #1449 these metrics are rendered correctly in the metrics tab. However since commit 0d3842a these metric names are no longer supported and (silently) don't get ingested anymore. With this commit I'm relaxing the strictness of the metric name regex in order to support ingesting these metrics again.Ping @dasJ