feat: hydra-queue-runner-v2#1517
Conversation
Conni2461
force-pushed
the
queue-runner-v2
branch
from
3e1ee11 to
d2bafdd
Compare
|
What does this do? |
Conni2461
force-pushed
the
queue-runner-v2
branch
2 times, most recently
from
700b51e to
c18c413
Compare
src/meson.build
Outdated
| ) | ||
|
|
||
| rust_binaries = { | ||
| 'queue-runner': 'hydra-queue-runner-v2', |
There was a problem hiding this comment.
I would personally drop the -v2 suffix. It would be something we will carry with us forever, even with the old queue runner long gone
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Conni2461
force-pushed
the
queue-runner-v2
branch
4 times, most recently
from
48c2119 to
3687c25
Compare
| format!( | ||
| "s3://store2?region=unknown&endpoint=http://localhost:9000&scheme=http&write-nar-listing=1&compression=zstd&ls-compression=br&log-compression=br&secret-key={}/../../example-secret-key&profile=local_nix_store", | ||
| env!("CARGO_MANIFEST_DIR") | ||
| ).parse()?, |
There was a problem hiding this comment.
This seems hardcoded, It would be nice if this was an environment variable for the secret key instead, so that way hydra can be expanded to not only being used in nixpkgs, but other places can locally run hydra while not exposing a secret key path at the store. If hydra want's to be used outside of nixpkgs, this will be one thing that will need changing. But overall I think personally and the best for security, the s3 URL and the S3 secret-key should have some environment variables to define to configure it, but leave the other arguments as thoses at runtime don't need to be secretive.
Conni2461
force-pushed
the
queue-runner-v2
branch
from
3687c25 to
7d9f536
Compare
Merges upstream master (including nix-2.34 PR NixOS#1575) into Helsinki's queue-runner PR NixOS#1517 to bring the branch up to date without modifying the original PR commit.
Merges upstream master (including git config isolation and nix-2.34 PR NixOS#1575) into Helsinki's original queue-runner PR NixOS#1517 commit to bring the branch up to date without modifying the original PR commit.
7 participants
Uh oh!
There was an error while loading. Please reload this page.