Skip to content

allow symbolic indexing of vectors of observables #41

Merged
MasonProtter merged 6 commits intoNeuroblox:masterfrom
vyudu:obs
Sep 5, 2025
Merged

allow symbolic indexing of vectors of observables #41
MasonProtter merged 6 commits intoNeuroblox:masterfrom
vyudu:obs

Conversation

@vyudu
Copy link
Copy Markdown
Contributor

@vyudu vyudu commented Aug 13, 2025

fix #38

Comment thread src/symbolic_indexing.jl Outdated
Comment thread src/symbolic_indexing.jl Outdated
@MasonProtter
Copy link
Copy Markdown
Collaborator

We'll also want a method in ext/MTKExt.jl that converts Nums to Symbols, i.e.

function SymbolicIndexingInterface.observed(sys::PartitionedGraphSystem, vars::Union{Vector{Num}, Tuple{Vararg{Num}}})
    SymbolicIndexingInterface.observed(sys, tosymbol.(vars; escape=false))
end

vyudu and others added 3 commits August 14, 2025 09:07
Co-authored-by: Mason Protter <mason.protter@icloud.com>
Co-authored-by: Mason Protter <mason.protter@icloud.com>
@vyudu
Copy link
Copy Markdown
Contributor Author

vyudu commented Aug 27, 2025

@MasonProtter is this waiting on something?

@MasonProtter
Copy link
Copy Markdown
Collaborator

Oops, im sorry I forgot about this! Could you just change the test so that it gets run by CI?

It's currently just in a free-floating file i think

Comment thread src/symbolic_indexing.jl Outdated
@vyudu
Copy link
Copy Markdown
Contributor Author

vyudu commented Sep 5, 2025

fixedup, should be mergeable

@MasonProtter MasonProtter merged commit 2ab9554 into Neuroblox:master Sep 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support vectors of Observed variables in the SymbolicIndexingInterface

2 participants