Skip to content

Upgrade to torch 2.9.1 and allow python 3.13#1266

Merged
dxqb merged 15 commits intoNerogar:masterfrom
dxqb:torch_2_10
Feb 17, 2026
Merged

Upgrade to torch 2.9.1 and allow python 3.13#1266
dxqb merged 15 commits intoNerogar:masterfrom
dxqb:torch_2_10

Conversation

@dxqb
Copy link
Collaborator

@dxqb dxqb commented Jan 24, 2026

git fetch origin pull/1266/head:pr-1266
git switch pr-1266

then update.sh / update.bat

based on #1189 and #1125 (comment)

Torch 2.9.1 #1189 has been well-tested but has not provided a clear benefit for us over torch 2.8, so we haven't upgraded yet. Maybe we skip 2.9.1 and go straight to 2.10 if that provides a benefit?

Does it fix

@dxqb
Copy link
Collaborator Author

dxqb commented Jan 25, 2026

don't upgrade rocm: pytorch/pytorch#173308

@lbosquett

This comment was marked as off-topic.

@dxqb
Copy link
Collaborator Author

dxqb commented Feb 14, 2026

on windows I was getting an error by training loras with Klein-9B and torch triton, I'm not sure if one these package upgrades solves it or by changing the kernel name from "__mm_kernel" to "_mm_kernel", but these changes solve it 🤷‍♂️

this was a torch bug introduced in torch 2.9 and is worked around by this PR. I guess you didn't use the torch version installed by OneTrainer before (2.8)

@dxqb
Copy link
Collaborator Author

dxqb commented Feb 14, 2026

@O-J1 IIRC you have already tested this PR. can you confirm?
I'm using it on linux successfully, but a test on Windows (especially Triton version) should be done before merge

@dxqb dxqb marked this pull request as ready for review February 14, 2026 11:22
@dxqb dxqb requested a review from O-J1 February 14, 2026 11:22
@O-J1
Copy link
Collaborator

O-J1 commented Feb 14, 2026

@O-J1 IIRC you have already tested this PR. can you confirm? I'm using it on linux successfully, but a test on Windows (especially Triton version) should be done before merge

Yes. Compiled and non compiled with SDXL and Flux 1 both worked on windows with an NVIDIA GPU on 2.10. The more recent upgrade ‘all dependencies’ PR is broken however.

dxqb and others added 4 commits February 15, 2026 15:16
Co-authored-by: O-J1 <18110006+O-J1@users.noreply.github.com>
Co-authored-by: O-J1 <18110006+O-J1@users.noreply.github.com>
Added note regarding PyTorch upgrade issue.
@dxqb dxqb linked an issue Feb 15, 2026 that may be closed by this pull request
@dxqb
Copy link
Collaborator Author

dxqb commented Feb 15, 2026

torch 2.10 has a significant vram regression, that would break user settings and presets:
pytorch/pytorch#175058

We can upgrade to 2.9.1 instead, or wait for torch 2.11 and/or a workaround

@dxqb dxqb added the waiting waiting for something / cannot fix currently label Feb 15, 2026
@dxqb dxqb mentioned this pull request Feb 15, 2026
@dxqb dxqb changed the title Upgrade to torch 2.10 Upgrade to torch 2.9.1 and python 3.13 Feb 17, 2026
@dxqb dxqb changed the title Upgrade to torch 2.9.1 and python 3.13 Upgrade to torch 2.9.1 and allow python 3.13 Feb 17, 2026
@dxqb dxqb removed the waiting waiting for something / cannot fix currently label Feb 17, 2026
@dxqb dxqb linked an issue Feb 17, 2026 that may be closed by this pull request
@dxqb dxqb linked an issue Feb 17, 2026 that may be closed by this pull request
@dxqb dxqb merged commit 26eaaca into Nerogar:master Feb 17, 2026
1 check passed
@dxqb dxqb deleted the torch_2_10 branch February 17, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Support Python 3.13 [Bug]: Compile transformer blocks when on Windows / MAX_PATH

3 participants