Upgrade to torch 2.9.1 and allow python 3.13#1266
Conversation
|
don't upgrade rocm: pytorch/pytorch#173308 |
This comment was marked as off-topic.
This comment was marked as off-topic.
this was a torch bug introduced in torch 2.9 and is worked around by this PR. I guess you didn't use the torch version installed by OneTrainer before (2.8) |
|
@O-J1 IIRC you have already tested this PR. can you confirm? |
Yes. Compiled and non compiled with SDXL and Flux 1 both worked on windows with an NVIDIA GPU on 2.10. The more recent upgrade ‘all dependencies’ PR is broken however. |
Co-authored-by: O-J1 <18110006+O-J1@users.noreply.github.com>
Co-authored-by: O-J1 <18110006+O-J1@users.noreply.github.com>
Added note regarding PyTorch upgrade issue.
|
torch 2.10 has a significant vram regression, that would break user settings and presets: We can upgrade to 2.9.1 instead, or wait for torch 2.11 and/or a workaround |
then update.sh / update.bat
based on #1189 and #1125 (comment)
Torch 2.9.1 #1189 has been well-tested but has not provided a clear benefit for us over torch 2.8, so we haven't upgraded yet. Maybe we skip 2.9.1 and go straight to 2.10 if that provides a benefit?
Does it fix
OneTrainer/modules/util/compile_util.py
Line 8 in 661872c