Skip to content

Ssc 1378 custom generation lifetime#2166

Open
brtietz wants to merge 11 commits intodevelopfrom
ssc_1378_custom_generation_lifetime
Open

Ssc 1378 custom generation lifetime#2166
brtietz wants to merge 11 commits intodevelopfrom
ssc_1378_custom_generation_lifetime

Conversation

@brtietz
Copy link
Copy Markdown
Collaborator

@brtietz brtietz commented Apr 6, 2026

Pull Request Template

Description

Add lifetime mode to custom generation profile with appropriate additional data handling

Fixes NatLabRockies/ssc#1371 and NatLabRockies/ssc#1378

Corresponding branches and PRs:

SSC branch ssc_1378_custom_generation_lifetime, develop for other repos

NatLabRockies/ssc#1384

Unit Test Impact:

No test impact expected on SAM

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@brtietz brtietz added this to the SAM 2026 Release milestone Apr 6, 2026
@brtietz brtietz added enhancement requires help revision Requires a Help revision before releasing public version labels Apr 6, 2026
@cpaulgilman
Copy link
Copy Markdown
Collaborator

@brtietz My testing looks good so far. A couple of things to confirm:

  1. The Calculate generation profiles and nameplate capacitiy from open cases option only uses Year 1 data when cases to be combined run lifetime simulations. (It also only works for hourly simulations.) This pull request does not change that behavior.
  2. This PR does not address Lifetime matrix in annual or single value mode with subhourly time steps #2161.

Is that correct and intended?

@cpaulgilman
Copy link
Copy Markdown
Collaborator

For a the attached .sam file and associated 15-minute resource data files, I get a simulation error:

compute fail(hybrid): custom_generation execution error. exec fail(generic): Failed to accumulate time series (hourly or subhourly): gen to monthly: monthly_energy
Simulation Hybrid failed :compute fail(hybrid): custom_generation execution error. exec fail(generic): Failed to accumulate time series (hourly or subhourly): gen to monthly: monthly_energy

custom-generation-lifetime-test.zip

@cpaulgilman
Copy link
Copy Markdown
Collaborator

@brtietz My testing looks good so far. A couple of things to confirm:

1. The **Calculate generation profiles and nameplate capacitiy from open cases** option only uses Year 1 data when cases to be combined run lifetime simulations. (It also only works for hourly simulations.) This pull request does not change that behavior.

2. This PR does not address [Lifetime matrix in annual or single value mode with subhourly time steps #2161](https://github.com/NatLabRockies/SAM/issues/2161).

Is that correct and intended?

For Item 1, see #2167.

Item 2 should be addressed in a separate pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement requires help revision Requires a Help revision before releasing public version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a lifetime input option to custom generation profile plant

3 participants