fix(k8s): document image digest pinning for production deployments#1480
fix(k8s): document image digest pinning for production deployments#1480dknos wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe Kubernetes manifest was updated to pin container images by SHA256 digest instead of mutable tags. Three container image references (dind, workspace, and init-docker-config) were replaced with fully qualified, digest-pinned versions to eliminate tag mutability risks. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@k8s/nemoclaw-k8s.yaml`:
- Line 29: Replace the mutable image tags in the k8s/nemoclaw-k8s.yaml manifest
with immutable image digests: locate the image: fields currently set to
docker:24-dind and the other two mutable tags and change them to fully qualified
references using the tag plus `@sha256`:<digest> (e.g. name:tag@sha256:...) or
split dev/prod manifests and pin only the production overlay; ensure the three
occurrences (the image: entries referenced in the comment) are updated so
deployments use the pinned digests rather than mutable tags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 38afd286-483f-4169-8c73-eb06f57d5362
📒 Files selected for processing (2)
k8s/nemoclaw-k8s.yamlnemoclaw-blueprint/policies/presets/huggingface.yaml
Pin docker:24-dind, node:22, and busybox images by digest to prevent supply chain drift from mutable tags. Fixes NVIDIA#1436 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
60fb97f to
d24731e
Compare
|
Updated — images are now pinned by SHA256 digest. Removed out-of-scope huggingface.yaml change. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
dknos
left a comment
There was a problem hiding this comment.
Confirmed resolved: all three container image references in k8s/nemoclaw-k8s.yaml now use @sha256: digest pinning (docker:24-dind, node:22, busybox). Comments about digest pinning have been replaced with actual pinned image fields. CodeRabbit's latest re-review marked the file as trivially changed with no actionable comments.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
:latest,:24-dind,:22can drift unexpectedly, creating supply chain riskTest plan
kubectl apply --dry-run=clientFixes #1436
🤖 Generated with Claude Code
Summary by CodeRabbit