feat(cli): add --json output for list, status, and policy-list commands#1475
Open
ac12644 wants to merge 2 commits intoNVIDIA:mainfrom
Open
feat(cli): add --json output for list, status, and policy-list commands#1475ac12644 wants to merge 2 commits intoNVIDIA:mainfrom
ac12644 wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Add a --json flag to three CLI commands for machine-readable output: - nemoclaw list --json - nemoclaw <name> status --json - nemoclaw <name> policy-list --json JSON mode reads directly from the local registry without requiring a live OpenShell gateway, making it safe for scripting and CI pipelines. Fixes NVIDIA#753 Signed-off-by: Abhishek Chauhan <ac12644@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a --json flag to the CLI for Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI as Nemoclaw CLI
participant FS as Filesystem (sandboxes.json)
participant Nim as nim module
User->>CLI: run `nemoclaw list --json` / `nemoclaw <name> status --json` / `policy-list --json`
CLI->>FS: read sandbox metadata (e.g., .nemoclaw/sandboxes.json)
alt status needs nim info
CLI->>Nim: nimStatusByName or nimStatus(sandboxName)
Nim-->>CLI: nim status (running/healthy/container)
end
CLI-->>User: emit JSON object (sandboxes / defaultSandbox / nim / presets / applied)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
bin/nemoclaw.js (1)
1486-1517:⚠️ Potential issue | 🟠 MajorAdd missing
nemoclaw status --jsonsupport to match the stated acceptance scope.The global
statuscommand path still ignores flags (showStatus()is called withoutargs), sonemoclaw status --jsonis not implemented even though it is in the linked objective scope.Suggested patch
-function showStatus() { +function showStatus(args = []) { + const jsonMode = args.includes("--json"); + // Show sandbox registry const { sandboxes, defaultSandbox } = registry.listSandboxes(); + if (jsonMode) { + // Keep this schema stable for automation. + console.log( + JSON.stringify( + { + sandboxes: sandboxes.map((sb) => ({ + name: sb.name, + default: sb.name === defaultSandbox, + model: sb.model || null, + provider: sb.provider || null, + gpuEnabled: sb.gpuEnabled || false, + policies: sb.policies || [], + createdAt: sb.createdAt || null, + })), + defaultSandbox, + }, + null, + 2, + ), + ); + return; + } + if (sandboxes.length > 0) { const live = parseGatewayInference( captureOpenshell(["inference", "get"], { ignoreError: true }).output, @@ case "status": - showStatus(); + showStatus(args); break;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bin/nemoclaw.js` around lines 1486 - 1517, The global "status" branch ignores CLI flags because it calls showStatus() with no arguments; update the switch case to pass the parsed args (call showStatus(args)) and ensure the showStatus function signature/handler accepts and respects flags like --json so `nemoclaw status --json` works; locate the GLOBAL_COMMANDS switch, the cmd variable handling, and the showStatus function to make the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@bin/nemoclaw.js`:
- Around line 1486-1517: The global "status" branch ignores CLI flags because it
calls showStatus() with no arguments; update the switch case to pass the parsed
args (call showStatus(args)) and ensure the showStatus function
signature/handler accepts and respects flags like --json so `nemoclaw status
--json` works; locate the GLOBAL_COMMANDS switch, the cmd variable handling, and
the showStatus function to make the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ac1b1681-baf8-4170-a683-eb8d18c0ae86
📒 Files selected for processing (2)
bin/nemoclaw.jstest/json-output.test.js
wscurran
added
NemoClaw CLI
Contributor
|
✨ Thanks for submitting this pull request, which proposes a way to enhance the |
# Conflicts: # bin/nemoclaw.js
ac12644
force-pushed
the
feat/json-output
branch
from
b0843b7 to
d8108e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
--jsonflag to three CLI commands for machine-readable output, enabling scripting and CI integration.nemoclaw list --jsonnemoclaw <name> status --jsonnemoclaw <name> policy-list --jsonJSON mode reads directly from the local registry without requiring a live OpenShell gateway, making it safe for offline scripting.
Example
Test plan
test/json-output.test.jscovering all three commandsnemoclaw list --json | jq ...)--jsonis omittedFixes #753
Summary by CodeRabbit
New Features
Tests
Documentation
Chores