Skip to content

[DO NOT MERGE] Dummy commit/PR to test TE DCP modifications.#3661

Draft
cspades wants to merge 1 commit intoNVIDIA:mainfrom
cspades:cye/te-dcp-test
Draft

[DO NOT MERGE] Dummy commit/PR to test TE DCP modifications.#3661
cspades wants to merge 1 commit intoNVIDIA:mainfrom
cspades:cye/te-dcp-test

Conversation

@cspades
Copy link
Copy Markdown
Member

@cspades cspades commented Mar 3, 2026

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@cspades cspades self-assigned this Mar 3, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 3, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cspades
Copy link
Copy Markdown
Member Author

cspades commented Mar 3, 2026

/ok to test ca8e26d

@Phlip79
Copy link
Copy Markdown
Member

Phlip79 commented Mar 4, 2026

We are changing our review process and marking all open, unlabeled PRs as draft. This change will go in effect starting once #3659 is merged.

Moving forward, all PRs will be required to start as draft PRs. If you wish to get your PR merged, mark your PR as “Ready for review”. Read more about the new process at submit.md.

@Phlip79 Phlip79 marked this pull request as draft March 4, 2026 22:36
@cspades cspades force-pushed the cye/te-dcp-test branch 2 times, most recently from 5cc695f to 8e7d246 Compare March 9, 2026 18:37
@cspades
Copy link
Copy Markdown
Member Author

cspades commented Mar 9, 2026

/ok to test 8e7d246

Signed-off-by: Cory Ye <cye@nvidia.com>
@cspades
Copy link
Copy Markdown
Member Author

cspades commented Mar 17, 2026

/ok to test e0b0528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants