-
Notifications
You must be signed in to change notification settings - Fork 93
Documentation Restructurting #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Documentation Development | ||
|
|
||
| - [Documentation Development](#documentation-development) | ||
| - [Build the Documentation](#build-the-documentation) | ||
| - [Live Building](#live-building) | ||
|
|
||
|
|
||
| ## Build the Documentation | ||
|
|
||
| The following sections describe how to set up and build the NeMo RL documentation. | ||
|
|
||
| Switch to the documentation source folder and generate HTML output. | ||
|
|
||
| ```sh | ||
| cd docs/ | ||
| uv run --group docs sphinx-build . _build/html | ||
| ``` | ||
|
|
||
| * The resulting HTML files are generated in a `_build/html` folder that is created under the project `docs/` folder. | ||
| * The generated python API docs are placed in `apidocs` under the `docs/` folder. | ||
|
|
||
| ## Checking for Broken Links | ||
|
|
||
| To check for broken http links in the docs, run this command: | ||
|
|
||
| ```sh | ||
| cd docs/ | ||
| uv run --group docs sphinx-build --builder linkcheck . _build/linkcheck | ||
| ``` | ||
|
|
||
| It will output a JSON file at `_build/linkcheck/output.json` with links it found while building the | ||
| docs. Records will have a status of `broken` if the link is not reachable. The `docs/conf.py` file is | ||
| configured to ignore github links because the CI test will often experience rate limit errors. | ||
| Comment out the `linkcheck_ignore` variable there to check all the links. | ||
|
|
||
| ## Live Building | ||
|
|
||
| When writing documentation, it can be helpful to serve the documentation and have it update live while you edit. | ||
|
|
||
| To do so, run: | ||
|
|
||
| ```sh | ||
| cd docs/ | ||
| uv run --group docs sphinx-autobuild . _build/html --port 12345 --host 0.0.0.0 | ||
| ``` | ||
|
|
||
| Open a web browser and go to `http://${HOST_WHERE_SPHINX_COMMAND_RUN}:12345` to view the output. |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It picked up my VSCode settings and I removed them, but I must have forgotten the ",". I can remove it, which makes it easier. Just let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let's remove changes to this file in this PR. Can follow up in a separate PR if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed!