Draft
Conversation
- Register gemma4 in AUTOMODEL_FACTORY (utils.py) - Add KV sharing support: use_cache=True for models with num_kv_shared_layers > 0 (train.py) - Freeze visual/audio encoders for text-only training to fix checkpoint resume (setup.py) - Inject mm_token_type_ids for Gemma4 text-only inputs (train.py, dtensor_policy_worker.py) - Extend skip_tokenizer_init workaround to Gemma4ForConditionalGeneration (vllm_worker.py) - Bump transformers 5.3.0 -> 5.5.0, vllm 0.17.1 -> 0.19.0 (pyproject.toml) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shuang Yu <shuangy@nvidia.com>
- grpo-gemma4-e2b-it-1n8g-fsdp2-automodel.yaml: E2B-it on 1 node - dapo-gemma4-31b-it-4n8g-fsdp2.yaml: 31B-it DAPO with dynamic sampling Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Contributor
Author
|
/ok to test b3b4d3c |
zpqiu
added
CI:L1
- Apply ruff-format line wrapping to setup.py, train.py, dtensor_policy_worker.py - Minimize recipe YAMLs (remove redundant defaults matching base config) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shuang Yu <shuangy@nvidia.com>
zpqiu
added
CI:L1
sharonyu-115
added
CI:L1
zpqiu
added
CI:L1
Contributor
|
/ok to test 360cb8a |
Regenerated lockfile to match pyproject.toml dependency bumps. Required for CI build container (uv sync --locked). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Contributor
Author
|
/ok to test 7353904 |
Regenerated with pinned Automodel submodule (92635e74) in CI base image (cuda-dl-base:25.05) to match CI's uv sync --locked. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Contributor
Author
|
/ok to test e90e80c |
Contributor
Author
|
/ok to test 04fc41c |
Contributor
Author
|
/ok to test 9d9fd36 |
sharonyu-115
force-pushed
the
gemma4-support
branch
from
9d9fd36 to
13ab087
Compare
Update Automodel submodule from 92635e74 to 3a3f6858 (latest main). Fixes CI test_automodel_types.py TypeError caused by check_model_inputs API change in transformers 5.5.0. Regenerate uv.lock. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shuang Yu <shuangy@nvidia.com>
vLLM 0.19.0 refactored chat preprocessing from OpenAIServingChat into a new OpenAIServingRender service class. This broke the NeMo-RL HTTP server in two ways: (1) OpenAIServingChat/Tokenization now require an openai_serving_render constructor arg, and (2) the _preprocess_chat method override was silently dead since it moved to OpenAIServingRender. Move the prefix-token replacement logic into a NeMoRLOpenAIServingRender subclass that overrides preprocess_chat, and pass it to both serving classes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Add missing test suite scripts for the two new Gemma 4 recipe configs to fix the test_all_recipe_yamls_accounted_for_in_test_suites CI check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Temporarily remove --exitfirst (-x) from pytest addopts so CI runs all tests instead of stopping at the first failure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shuang Yu <shuangy@nvidia.com>
sharonyu-115
force-pushed
the
gemma4-support
branch
from
13ab087 to
23e1d27
Compare
Contributor
Author
|
/ok to test 23e1d27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
To address #2212
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information