fix: convert_dcp_to_hf.py correctly loads saved tokenizer from DCP if detected#2210
Open
fix: convert_dcp_to_hf.py correctly loads saved tokenizer from DCP if detected#2210
Conversation
…ted. Signed-off-by: Daniel Egert <degert@nvidia.com>
Contributor
|
@RayenTian could you help to take a review? |
Contributor
Signed-off-by: Daniel Egert <degert@nvidia.com>
…dcp-conversion-fix
Contributor
|
/ok to test 698757c |
yuki-97
approved these changes
Apr 13, 2026
Contributor
|
hi @trias702 , there's a lint check fail, could you help to fix? |
Author
Sorry, I don't understand why it's failing. I'm afraid I don't know much about linting or how it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixed convert_dcp_to_hf.py to load the tokenizer directory when detected.
Usage
Before your PR is "Ready for review"
Pre checks:
Additional Information