Skip to content

Reset Time Signal (NGWPC-9621) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idtodd merged 9 commits into from
Mar 13, 2026
Merged

Reset Time Signal (NGWPC-9621) #5

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2d75604
Reset time implementation
idtodd Jan 22, 2026
482ab9f
Add size as header to serialized data
idtodd Feb 5, 2026
b35249c
Fix stream copy length
idtodd Feb 6, 2026
a776e34
Return success on reset time
idtodd Feb 18, 2026
50913d6
Fix array size for serialized properties
idtodd Mar 5, 2026
e5be717
Account for changing Q size
idtodd Mar 5, 2026
b946fd6
Explicit void* to double* cast
idtodd Mar 5, 2026
b996a99
Adjust serailized values to capture array size changes
idtodd Mar 6, 2026
7be1ba7
Fix malloc size calculation
idtodd Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/bmi_topmodel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,9 @@ static int Get_var_type(Bmi *self, const char *name, char *type) {
} else if (strcmp(name, "serialization_free") == 0) {
strncpy(type, "int", BMI_MAX_TYPE_NAME);
return BMI_SUCCESS;
} else if (strcmp(name, "reset_time") == 0) {
strncpy(type, "double", BMI_MAX_TYPE_NAME);
return BMI_SUCCESS;
}
// If we get here, it means the variable name wasn't recognized
type[0] = '\0';
Expand Down Expand Up @@ -776,7 +779,10 @@ static int Get_var_nbytes(Bmi *self, const char *name, int *nbytes) {
}
// special cases for save state
if (item_count < 1) {
if (strcmp(name, "serialization_create") == 0 || strcmp(name, "serialization_size") == 0 || strcmp(name, "serialization_free") == 0) {
if (strcmp(name, "serialization_create") == 0
|| strcmp(name, "serialization_size") == 0
|| strcmp(name, "serialization_free") == 0
|| strcmp(name, "reset_time") == 0) {
item_count = 1;
} else if (strcmp(name, "serialization_state") == 0) {
topmodel_model* model = (topmodel_model*)self->data;
Expand Down Expand Up @@ -1063,6 +1069,10 @@ static int Set_value(Bmi *self, const char *name, void *array) {
} else {
return BMI_FAILURE;
}
} else if (strcmp(name, "reset_time") == 0) {
topmodel_model* model = (topmodel_model *)self->data;
// current_time_step is mainly used for indexing into config data, so should be safe to reset and nothing else
model->current_time_step = 0;
}

if (self->get_value_ptr(self, name, &dest) == BMI_FAILURE)
Expand Down
Loading