[CLEANUP] Make AbstractHtmlProcessor::domDocument private#1621
Conversation
Also make it non-nullable as it will never be read before initialization. Access to the property already is guarded by the `getDomDocument()` accessor, which we'll need to keep as we access it from the outside. We cannot guard the getter's code with an `assert` as PHPStan would complain about a useless assert there. So rely on PHP throwing an error if the getter is called before the property is initialized. Also improve some related comments.
oliverklee
added this to the
8.3.0 New features, bug fixes, and performance improvements milestone
|
coverage: 97.669% (-0.003%) from 97.672% — cleanup/non-nullable-dom-document into main |
| * | ||
| * @throws \UnexpectedValueException |
There was a problem hiding this comment.
getHtmlElement() currently throws this exception if there is no <html> element, which would only be the case if loadHTML() failed. But the documentation doesn't indicate under which circumstances it would fail, merely stating "malformed HTML should load successfully".
So perhaps we can assume that there will always be an <html> element, and change getHtmlElement() to assert() so as a separate PR. (Also, calling methods aren't currently declared with this @throws annotation.)
We could set |
3 participants
Also make it non-nullable as it will never be read before initialization.
Access to the property already is guarded by the
getDomDocument()accessor, which we'll need to keep as we access it from the outside.We cannot guard the getter's code with an
assertas PHPStan would complain about a useless assert there. So rely on PHP throwing an error if the getter is called before the property is initialized.Also improve some related comments.