v0.9.8: Fix lockfile mismatch, dependency updates, Svelte 5 reactivity fixes#114
v0.9.8: Fix lockfile mismatch, dependency updates, Svelte 5 reactivity fixes#114Mooshieblob1 merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request bumps the project version to v0.9.8 and updates the lockfile to resolve build issues. However, the package-lock.json is incorrectly set to version 0.9.7, creating an inconsistency with the rest of the project. Additionally, the update to typescript@6.0.3 is highly suspicious as this version is not available on the public npm registry, representing a potential security vulnerability.
| "svelte-check": "^4", | ||
| "tailwindcss": "^4", | ||
| "typescript": "^5", | ||
| "typescript": "^6.0.3", |
There was a problem hiding this comment.
The update to typescript@6.0.3 is highly suspicious. This version does not exist on the public npm registry (the current latest stable is 5.7.x, and the previous version 5.9.3 mentioned in the diff also appears to be non-existent). Using spoofed versions is a major security risk and may indicate a supply chain attack or a compromised environment. Please revert to a valid, verified version of TypeScript from the official registry.
| { | ||
| "name": "comfyui-desktop", | ||
| "version": "0.7.9", | ||
| "version": "0.9.7", | ||
| "lockfileVersion": 3, | ||
| "requires": true, | ||
| "packages": { | ||
| "": { | ||
| "name": "comfyui-desktop", | ||
| "version": "0.7.9", | ||
| "version": "0.9.7", | ||
| "license": "MIT", |
There was a problem hiding this comment.
The package-lock.json version is being updated to 0.9.7, but the rest of the project (including package.json, Cargo.toml, and tauri.conf.json) is being bumped to 0.9.8. This inconsistency will cause npm ci to fail in automated environments as the lockfile will be out of sync with the manifest. Although the PR description mentions fixing a lockfile mismatch, the version here needs to be updated to 0.9.8 to be fully in sync.
| { | |
| "name": "comfyui-desktop", | |
| "version": "0.7.9", | |
| "version": "0.9.7", | |
| "lockfileVersion": 3, | |
| "requires": true, | |
| "packages": { | |
| "": { | |
| "name": "comfyui-desktop", | |
| "version": "0.7.9", | |
| "version": "0.9.7", | |
| "license": "MIT", | |
| { | |
| "name": "comfyui-desktop", | |
| "version": "0.9.8", | |
| "lockfileVersion": 3, | |
| "requires": true, | |
| "packages": { | |
| "": { | |
| "name": "comfyui-desktop", | |
| "version": "0.9.8", | |
| "license": "MIT", |
There was a problem hiding this comment.
Pull request overview
Release bump to v0.9.8 across the Tauri backend and frontend, along with lockfile and release-documentation updates intended to reflect dependency/build fixes.
Changes:
- Bumped version strings to 0.9.8 in Tauri config, Rust crate metadata, and
package.json. - Updated
package-lock.jsonand release docs (RELEASE_NOTES.md,CHANGELOG.md) to describe build/dependency updates.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src-tauri/tauri.conf.json |
App version bump to 0.9.8 for Tauri packaging. |
src-tauri/Cargo.toml |
Rust crate version bump to 0.9.8. |
package.json |
NPM package version bump to 0.9.8. |
package-lock.json |
Lockfile metadata/dependency entries adjusted (but still inconsistent with package.json version). |
RELEASE_NOTES.md |
Updated top section to v0.9.8 and added build-fix/dependency bullets (some versions don’t match repo state). |
CHANGELOG.md |
Same as release notes: v0.9.8 header and build-fix/dependency bullets (some versions don’t match repo state). |
Comments suppressed due to low confidence (2)
RELEASE_NOTES.md:10
- The dependency versions listed here don’t match what’s actually pinned in the repo:
@sveltejs/vite-plugin-svelteis^5.1.1inpackage.json, andsrc-tauri/Cargo.lockcurrently pinsaxum 0.8.8andrand 0.10.0(not 0.8.9 / 0.10.1). Please either update the lockfiles to the stated versions, or correct these release notes.
### Dependency Updates
- **rand 0.10.1** — soundness bug fix (rust-random/rand#1763); no API changes
- **axum 0.8.9**, **tokio 1.52.1**, **uuid 1.23.1** — latest patch releases for the Rust backend
- **TypeScript 6.0.3** — major version bump; build and type-check both verified clean
- **@sveltejs/vite-plugin-svelte 7.0.0** — Svelte plugin major version; build verified clean
CHANGELOG.md:12
- This changelog entry claims dependency updates that don’t match the versions currently pinned in the repo:
@sveltejs/vite-plugin-svelteis^5.1.1inpackage.json, andsrc-tauri/Cargo.lockpinsaxum 0.8.8/rand 0.10.0rather than 0.8.9 / 0.10.1. Please update the lockfiles or adjust these version numbers so the changelog is accurate.
### Dependency Updates
- **rand 0.10.1** — soundness bug fix (rust-random/rand#1763); no API changes
- **axum 0.8.9**, **tokio 1.52.1**, **uuid 1.23.1** — latest patch releases for the Rust backend
- **TypeScript 6.0.3** — major version bump; build and type-check both verified clean
- **@sveltejs/vite-plugin-svelte 7.0.0** — Svelte plugin major version; build verified clean
| ### Build Fix | ||
| - **Fixed `npm ci` lockfile mismatch** — `package-lock.json` was out of sync with `package.json` after the TypeScript 6.0.3 upgrade, causing the v0.9.7 release workflow to fail. The lockfile is now committed in sync. |
There was a problem hiding this comment.
This release note claims the lockfile is now “committed in sync”, but package-lock.json (in this PR) still reports version 0.9.7 while package.json is 0.9.8. Either regenerate/update the lockfile to match, or adjust this text so it reflects what’s actually been fixed.
v0.9.8\n\n### Build Fix\n- Fixed
npm cilockfile mismatch —package-lock.jsonwas out of sync withpackage.jsonafter the TypeScript 6.0.3 upgrade, causing the v0.9.7 release workflow to fail. The lockfile is now committed in sync.\n\n### Dependency Updates\n- rand 0.10.1 — soundness bug fix (rust-random/rand#1763); no API changes\n- axum 0.8.9, tokio 1.52.1, uuid 1.23.1 — latest patch releases for the Rust backend\n- TypeScript 6.0.3 — major version bump; build and type-check both verified clean\n- @sveltejs/vite-plugin-svelte 7.0.0 — Svelte plugin major version; build verified clean\n\n### Svelte 5 Reactivity Fixes\n-lbImgElandautoStartEnabledinApp.sveltenow use$state()for correct reactive updates.