v0.9.7: Dependency updates and Svelte 5 reactivity fixes#113
v0.9.7: Dependency updates and Svelte 5 reactivity fixes#113Mooshieblob1 merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the project to version 0.9.7 and implements Svelte 5 reactivity using the $state rune for lbImgEl and autoStartEnabled. Feedback identifies several incorrect or non-existent dependency versions in the package.json and changelog, such as TypeScript 6.0.3 and rand 0.10.1, as well as a version discrepancy for the Svelte Vite plugin.
| "svelte-check": "^4", | ||
| "tailwindcss": "^4", | ||
| "typescript": "^5", | ||
| "typescript": "^6.0.3", |
There was a problem hiding this comment.
| }, | ||
| "devDependencies": { | ||
| "@sveltejs/vite-plugin-svelte": "^5", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", |
There was a problem hiding this comment.
| - **rand 0.10.1** — soundness bug fix (rust-random/rand#1763); no API changes | ||
| - **axum 0.8.9**, **tokio 1.52.1**, **uuid 1.23.1** — latest patch releases for the Rust backend | ||
| - **TypeScript 6.0.3** — major version bump; build and type-check both verified clean | ||
| - **@sveltejs/vite-plugin-svelte 7.0.0** — Svelte plugin major version; build verified clean |
There was a problem hiding this comment.
Several version numbers mentioned in this update appear to be incorrect or non-existent (e.g., rand 0.10.1, axum 0.8.9, tokio 1.52.1, TypeScript 6.0.3, and @sveltejs/vite-plugin-svelte 7.0.0). For instance, the latest stable version of rand is 0.8.5, and TypeScript is at 5.7.x. Please verify these versions and update the changelog to reflect the actual dependencies being used.
There was a problem hiding this comment.
Pull request overview
This PR targets the v0.9.7 release by bumping app versions across frontend/Tauri config, updating frontend devDependencies, and fixing two Svelte 5 reactivity issues in App.svelte so bind:this / conditional UI updates behave correctly under runes.
Changes:
- Make
lbImgElandautoStartEnabledreactive via$state()insrc/App.svelte. - Bump project version to
0.9.7acrosspackage.json,src-tauri/Cargo.toml, andsrc-tauri/tauri.conf.json. - Add v0.9.7 entries to
RELEASE_NOTES.mdandCHANGELOG.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/App.svelte | Declares lbImgEl and autoStartEnabled with $state() to restore Svelte 5 reactivity for bindings/conditionals. |
| src-tauri/tauri.conf.json | Bumps Tauri app version to 0.9.7. |
| src-tauri/Cargo.toml | Bumps Rust package version to 0.9.7. |
| package.json | Bumps npm package version to 0.9.7 and updates devDependencies (TypeScript, Svelte plugin). |
| RELEASE_NOTES.md | Adds v0.9.7 release notes section. |
| CHANGELOG.md | Adds v0.9.7 changelog section. |
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "@tailwindcss/vite": "^4", |
There was a problem hiding this comment.
The PR description / release notes say @sveltejs/vite-plugin-svelte 7.0.0, but package.json is still on the v5 line (^5.1.1). Either bump the dependency to match the stated upgrade, or update the PR description/release notes to reflect the actual version being shipped.
| - **rand 0.10.1** — soundness bug fix (rust-random/rand#1763); no API changes | ||
| - **axum 0.8.9**, **tokio 1.52.1**, **uuid 1.23.1** — latest patch releases for the Rust backend | ||
| - **TypeScript 6.0.3** — major version bump; build and type-check both verified clean | ||
| - **@sveltejs/vite-plugin-svelte 7.0.0** — Svelte plugin major version; build verified clean |
There was a problem hiding this comment.
These release notes list specific dependency versions (rand 0.10.1 / axum 0.8.9 / tokio 1.52.1 / uuid 1.23.1 / vite-plugin-svelte 7.0.0), but the repo’s lockfiles currently reflect different versions (e.g., src-tauri/Cargo.lock has axum 0.8.8, tokio 1.51.1, uuid 1.23.0, rand 0.10.0; package-lock.json is still TypeScript ^5 and vite-plugin-svelte ^5). Please either update the lockfiles to actually ship these versions, or adjust the release notes so they match what will be built.
| - **rand 0.10.1** — soundness bug fix (rust-random/rand#1763); no API changes | |
| - **axum 0.8.9**, **tokio 1.52.1**, **uuid 1.23.1** — latest patch releases for the Rust backend | |
| - **TypeScript 6.0.3** — major version bump; build and type-check both verified clean | |
| - **@sveltejs/vite-plugin-svelte 7.0.0** — Svelte plugin major version; build verified clean | |
| - **rand patch update** — includes the upstream soundness bug fix (rust-random/rand#1763) with no intended API changes | |
| - **Rust backend dependency patch updates** — refreshed backend crates including `axum`, `tokio`, and `uuid` | |
| - **TypeScript toolchain update** — build and type-check verified clean | |
| - **Svelte Vite plugin update** — build verified clean |
| - **rand 0.10.1** — soundness bug fix (rust-random/rand#1763); no API changes | ||
| - **axum 0.8.9**, **tokio 1.52.1**, **uuid 1.23.1** — latest patch releases for the Rust backend | ||
| - **TypeScript 6.0.3** — major version bump; build and type-check both verified clean | ||
| - **@sveltejs/vite-plugin-svelte 7.0.0** — Svelte plugin major version; build verified clean |
There was a problem hiding this comment.
This changelog entry claims dependency bumps to rand 0.10.1 / axum 0.8.9 / tokio 1.52.1 / uuid 1.23.1 / vite-plugin-svelte 7.0.0, but the current lockfiles in the repo show different versions (e.g., src-tauri/Cargo.lock has axum 0.8.8, tokio 1.51.1, uuid 1.23.0, rand 0.10.0; package-lock.json still pins TypeScript ^5 and vite-plugin-svelte ^5). Please update the lockfiles (or correct the entry) so the changelog reflects what will actually ship.
| - **rand 0.10.1** — soundness bug fix (rust-random/rand#1763); no API changes | |
| - **axum 0.8.9**, **tokio 1.52.1**, **uuid 1.23.1** — latest patch releases for the Rust backend | |
| - **TypeScript 6.0.3** — major version bump; build and type-check both verified clean | |
| - **@sveltejs/vite-plugin-svelte 7.0.0** — Svelte plugin major version; build verified clean | |
| - **rand 0.10.0** — current locked Rust RNG dependency version | |
| - **axum 0.8.8**, **tokio 1.51.1**, **uuid 1.23.0** — current locked Rust backend dependency versions | |
| - **TypeScript 5** — current locked frontend TypeScript major version | |
| - **@sveltejs/vite-plugin-svelte 5** — current locked Svelte plugin major version |
| "devDependencies": { | ||
| "@sveltejs/vite-plugin-svelte": "^5", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "@tailwindcss/vite": "^4", | ||
| "@tauri-apps/cli": "^2.10.1", | ||
| "@tsconfig/svelte": "^5.0.8", | ||
| "svelte": "^5", | ||
| "svelte-check": "^4", | ||
| "tailwindcss": "^4", | ||
| "typescript": "^5", | ||
| "typescript": "^6.0.3", | ||
| "vite": "^6" |
There was a problem hiding this comment.
npm ci is used in CI (see .github/workflows/release.yml), but package-lock.json is not updated alongside these devDependencies changes. As-is, CI will keep installing the old locked versions (e.g., TypeScript ^5 and @sveltejs/vite-plugin-svelte ^5), and npm ci may fail due to the lockfile being out of sync with package.json. Regenerate and commit an updated package-lock.json (and any other lockfile the repo actually uses) after bumping TypeScript / plugin versions.
v0.9.7
Dependency Updates
logrust-random/rand#1763); no API changesSvelte 5 Reactivity Fixes
lbImgElandautoStartEnabledinApp.sveltewere not declared with$state(), sobind:thison the lightbox image element and the auto-start toggle would not correctly trigger reactive updates. Both are now properly reactive.