fix: resolve merge conflicts for PR #94 and complete SKILL.md docs#113
Merged
RyanLee-Dev merged 3 commits intomainfrom Apr 24, 2026
Merged
fix: resolve merge conflicts for PR #94 and complete SKILL.md docs#113RyanLee-Dev merged 3 commits intomainfrom
RyanLee-Dev merged 3 commits intomainfrom
Conversation
- Auto-convert HTTP to HTTPS in downloadFile() to work around Alibaba Cloud OSS CDN blocking HTTP traffic from certain regions - Add --response-format <url|base64> flag for image generation - Add retry logic (3 attempts, exponential backoff) for download failures - Fixes image download failures with 'Network request failed' error Related: MiniMax API returns http:// URLs but OSS CDN requires https://
Resolve conflict in src/commands/image/generate.ts: keep both the base64 response format support (PR #94) and the file overwrite warning (main).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix/image-download-https) andmainimage generateflags toskill/SKILL.md:--seed,--width,--height,--prompt-optimizer,--aigc-watermark,--response-formatContext
PR #94 by @nguyenngothuong fixes image download failures caused by MiniMax API returning
http://URLs while Alibaba Cloud OSS CDN requireshttps://. See #93 for details.Test plan
mmx image generate --prompt "test" --out-dir ./out/works with HTTPS-forced downloadmmx image generate --prompt "test" --response-format base64 --out-dir ./out/saves base64 images correctlynpx tsc --noEmitpasses