Skip to content

Create only zip & pom for unobfuscated versions (26.1+) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LexManos merged 1 commit into from
Mar 25, 2026
Merged

Create only zip & pom for unobfuscated versions (26.1+) #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/main/java/net/minecraftforge/mcmaven/impl/repo/Repo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,15 +286,12 @@ protected List<PendingArtifact> mappingArtifacts(File cache, Mappings mappings,
outputJson.put("mappings.version", mappings::version);
}

// 26.1 has no mappings as they are not obfed, so just output the channel.
// In theory we need to add support for arbitrary mappings not just SRG.
// So i'll have to change this later, but we'll cross that bridge when we come to it.
if (!MCPConfigRepo.isObfuscated(side.getMCP().getMinecraftTasks().getVersion()))
return List.of();

var coords = mappings.getArtifact(side);
var csvs = pending("Mappings Zip", mappings.getCsvZip(side), coords, false);
var pom = pending("Mappings POM", simplePom(cache, coords), coords.withExtension("pom"), false);
// Just create the zip and pom for unobfuscated versions.
if (!MCPConfigRepo.isObfuscated(side.getMCP().getMinecraftTasks().getVersion()))
return List.of(csvs, pom);
var m2o = pending("Mappings map2obf", mappings.getMapped2Obf(side), coords.withClassifier("map2obf").withExtension("tsrg.gz"), false);
var m2s = pending("Mappings map2srg", mappings.getMapped2Srg(side), coords.withClassifier("map2srg").withExtension("tsrg.gz"), false);
if (outputJson != null) {
Expand Down
Loading