Skip to content

feat(social-controllers): add intent and category fields to Trade type #8410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bigshmow merged 5 commits into from
Apr 10, 2026
Merged

feat(social-controllers): add intent and category fields to Trade type #8410

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c87798
feat(social-controllers): add intent and category fields to Trade type
Bigshmow Apr 9, 2026
4480a26
chore: update CHANGELOG with PR #8410
Bigshmow Apr 9, 2026
241032a
feat: update validation schema
Bigshmow Apr 9, 2026
624ed68
refactor: derive Trade type from TradeStruct via Infer
Bigshmow Apr 9, 2026
3ba3a5a
chore: changelog reflect strict type
Bigshmow Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/social-controllers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `intent` and optional `category` fields to `Trade` type ([#8410](https://github.com/MetaMask/core/pull/8410))

### Changed

- Bump `@metamask/messenger` from `^1.1.0` to `^1.1.1` ([#8373](https://github.com/MetaMask/core/pull/8373))
Expand Down
1 change: 1 addition & 0 deletions packages/social-controllers/src/SocialService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const mockSocialHandles = {

const mockTrade = {
direction: 'buy',
intent: 'enter',
tokenAmount: 1.5,
usdCost: 3000,
timestamp: 1700000000,
Expand Down
2 changes: 2 additions & 0 deletions packages/social-controllers/src/SocialService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ const ProfileSummaryStruct = structType({

const TradeStruct = structType({
direction: string(),
intent: string(),
category: optional(string()),
tokenAmount: number(),
usdCost: number(),
timestamp: number(),
Expand Down
6 changes: 5 additions & 1 deletion packages/social-controllers/src/social-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,12 @@ export type SocialHandles = {
* A single trade within a position.
*/
export type Trade = {
/** "buy" or "sell". */
/** "buy" or "sell" (semi-deprecated by Clicker in favor of intent). */
direction: string;
/** "enter" or "exit" — preferred over direction. */
intent: string;
/** Trade category from Clicker (e.g. "receive" for airdrops/transfers). */
category?: string;
/** Quantity traded. */
tokenAmount: number;
/** USD value of the trade. */
Expand Down
Loading