Conversation
packages/authenticated-user-storage/tests/fixtures/authenticated-userstorage.ts
Show resolved
Hide resolved
| /** Keccak-256 hash uniquely identifying the delegation (0x-prefixed). */ | ||
| delegationHash: string; | ||
| /** Chain ID in hex format (0x-prefixed). */ | ||
| chainIdHex: string; |
There was a problem hiding this comment.
q - do we only support EVM?
Wondering if we can change the format to use CAIP-19 to support non-evm? That way we could remove chainId and tokenAddress and just have 1 field for assetId.
There was a problem hiding this comment.
@V00D00-child what do you think? i believe cash accounts team already implemted they v1. However we could look into using CAIP-10
There was a problem hiding this comment.
do we only support EVM
Yes, the Delegation Framework is only supported on EVM, so I think we should leave out using CAIP-19 for these types
packages/authenticated-user-storage/tests/mocks/authenticated-userstorage.ts
Outdated
Show resolved
Hide resolved
packages/authenticated-user-storage/src/authenticated-user-storage.ts
Outdated
Show resolved
Hide resolved
packages/authenticated-user-storage/src/authenticated-user-storage.test.ts
Show resolved
Hide resolved
packages/authenticated-user-storage/src/authenticated-user-storage.ts
Outdated
Show resolved
Hide resolved
packages/authenticated-user-storage/src/authenticated-user-storage.ts
Outdated
Show resolved
Hide resolved
packages/transaction-pay-controller/src/utils/source-amounts.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4be6409. Configure here.

Note
Medium Risk
Introduces new network-facing code that sends bearer tokens and persists user-related data via external APIs; while mostly additive, mistakes could impact auth/header handling and data validation behavior.
Overview
Adds a new package,
@metamask/authenticated-user-storage, providing anAuthenticatedUserStorageService(built onBaseDataService) that calls Authenticated User Storage API endpoints to list/create/revoke delegations and get/put notification preferences, including bearer-token auth, optionalX-Client-Typeheader support, runtime response validation, and cache invalidation.Wires the package into the monorepo (TypeScript project references,
yarn.lock, README package list/dependency graph) and updates ownership metadata (CODEOWNERS,teams.json), with accompanying Jest tests plus Nock fixtures/mocks and initial docs/changelog/license.Reviewed by Cursor Bugbot for commit 2339810. Bugbot is set up for automated code reviews on this repo. Configure here.