Skip to content

Fix umdp lower and camel case checking#219

Open
Pierre Siddall (Pierre-siddall) wants to merge 5 commits intoMetOffice:mainfrom
Pierre-siddall:fix-umdp3-casing
Open

Fix umdp lower and camel case checking#219
Pierre Siddall (Pierre-siddall) wants to merge 5 commits intoMetOffice:mainfrom
Pierre-siddall:fix-umdp3-casing

Conversation

@Pierre-siddall
Copy link
Copy Markdown
Contributor

@Pierre-siddall Pierre Siddall (Pierre-siddall) commented Mar 31, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: R Sharp (@r-sharp)

This PR fixes the umdp3 checker to correctly identify non lowercase and CamelCase variable names and subsequently output the correct number of failures in the script.

closes #214

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Tested on a UM source file and changed two variable names to upper case and changed one lowercase variable name to CamelCase. umdp3_conformance.py reported a failure in the appropriate file containing two errors as expected.

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

@Pierre-siddall Pierre Siddall (Pierre-siddall) marked this pull request as draft March 31, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix incorrect detection of Lowercase or CamelCase variable names only

2 participants