#835 replace test copyright headers with ruff rule CPY

[Jared Drayton (mo-jareddrayton)]

Closes #835

As noted by Ed (@mo-gill) the existing test_coding_standards.py doesn't actually test coding standards anymore and only checks for the copyright/license header. This PR replaces those tests in cdds and mip_convert with the ruff rule CPY (see https://docs.astral.sh/ruff/rules/#flake8-copyright-cpy)

A couple other changes include the removal of some spurious shebang lines and enabling the preview mode on ruff for the CPY rule.

[Matthew Mizielinski (matthew-mizielinski)]

LGTM and makes this test a lot easier.

[Ed (mo-gill)]

I take it that if we go ahead with this change we're just going to have to be aware from now on that it doesn't check non python files as opposed to the previous copyright checker which checked all of them?

[Jared Drayton (mo-jareddrayton)]

I'm not sure if you saw our discussion on teams about this Matthew Mizielinski (@matthew-mizielinski)?

If not, the tldr is that this rule will only check .py files. I don't know how big of an issue you consider this?

[Matthew Mizielinski (matthew-mizielinski)]

If not, the tldr is that this rule will only check .py files. I don't know how big of an issue you consider this?

The other files we have are .cfg and .json (no headers), and the odd .cylc, .conf in the workflows. I'm less worried about these, but perhaps we should do both for now (I have more confidence in ruff than the unit test we have).

[Jared Drayton (mo-jareddrayton)]

If not, the tldr is that this rule will only check .py files. I don't know how big of an issue you consider this?

The other files we have are .cfg and .json (no headers), and the odd .cylc, .conf in the workflows. I'm less worried about these, but perhaps we should do both for now (I have more confidence in ruff than the unit test we have).

I'm not even sure what files are being checked other than .py after looking at the list of excludes.

CDDS/cdds/cdds/tests/test_coding_standards.py

Lines 48 to 50 in 1eff13e

	['egg-info', 'EGG-INFO', 'dist', '.pyc', 'doctrees', 'html', 'cfg', 'clyc',
	'pylintrc', 'TAGS', 'json', 'todel', 'nfsc', 'txt', 'ini', 'conf', 'workflows']
	)

I'll put it back in for now but at least we're more likely to pick up copyright issues during development with ruff check.