Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaking change improves the design of the rounding model implemented in Zero to better conceptually mirror applications that mix values with and without uncertainties.
First and foremost, rounding of values with and without uncertainty is now separated by default. In the case that an uncertainty is present, what one usually wants is to round the value to the same digit as the uncertainty. This behavior is engaged by setting
round.follow-uncertaintyto true (which is the default). In this setting and optionally, theround.uncertainty-precisioncan be used to control the number of significant digits to round the uncertainty to before rounding the value.If
round.follow-uncertaintyis false or the number just has no uncertainty, the normal rounding method applies. In this case, there is of course no guarantee that value and uncertainty have the same number of digits.With this change the option
round.mode: "uncertainty"is removed and replaced by the new parameters.