Add support for G2 & G3 commands that use radius R instead of I & J.#544
Merged
MaslowCommunityGardenRobot merged 1 commit intoMaslowCNC:masterfrom May 21, 2020
Conversation
Author
|
Tested on physical machine by @Orob-Maslow with pictures in WebControlCNC/WebControl#137 |
Collaborator
|
Congratulations on the pull request @gb0101010101 Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged. I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)! |
Collaborator
|
Time is up and we're ready to merge this pull request. Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmitting PR #541