MDBF-1197: temporary windows msi builder hotfix regarding HeidiSQL download#944
Merged
RazvanLiviuVarzaru merged 1 commit intoMariaDB:devfrom Apr 3, 2026
Merged
Conversation
fauust
approved these changes
Apr 3, 2026
RazvanLiviuVarzaru
force-pushed
the
windows-hot-fix
branch
from
7db293a to
b68cb88
Compare
…wnload windows-packages builder failing with: ``` -- Downloading https://www.heidisql.com/downloads/releases/HeidiSQL_12.14_64_Portable.zip to C:/buildbot/workers/prod/amd64-windows-packages/build/tmpdir/HeidiSQL_12.14_64_Portable/HeidiSQL_12.14_64_Portable.zip cmake -E tar : error : ZIP decompression failed (-5) [C:\buildbot\workers\prod\amd64-windows-packages\build\win\packaging\MSI.vcxproj] ``` Because a file download 60 seconds timeout is reached in https://github.com/MariaDB/server/blob/9fc925d77163f1d63e21a65654b0f59678abf08d/win/packaging/heidisql.cmake#L9 The file download status if not checked in cmake, it will be silently ignored and cmake continues to decompression, resulting in the above error, due to an incomplete download. CMAKE is looking in TEMP for third parties, setting: THIRD_PARTY_DOWNLOAD_LOCATION https://github.com/MariaDB/server/blob/9fc925d77163f1d63e21a65654b0f59678abf08d/win/packaging/CMakeLists.txt#L139 But currently TEMP is set to a worker path build location that is removed on every run. WVlad will permanetly fix this by making THIRD_PARTY_DOWNLOAD_LOCATION settable in 10.6 and also increasing the timeout. Until then, I manually copied `HeidiSQL_12.14_64_Portable.zip` on the system and user TEMP location on the windows packages host, and will remove the TEMP env variable from the configuration, letting the system / user variable take precedence.
RazvanLiviuVarzaru
force-pushed
the
windows-hot-fix
branch
from
b68cb88 to
078cb47
Compare
RazvanLiviuVarzaru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-packages builder failing with:
Because a file download 60 seconds timeout is reached in https://github.com/MariaDB/server/blob/9fc925d77163f1d63e21a65654b0f59678abf08d/win/packaging/heidisql.cmake#L9
The file download status if not checked in cmake, it will be silently ignored and cmake continues to decompression, resulting in the above error, due to an incomplete download.
CMAKE is looking in TEMP for third parties, setting: THIRD_PARTY_DOWNLOAD_LOCATION https://github.com/MariaDB/server/blob/9fc925d77163f1d63e21a65654b0f59678abf08d/win/packaging/CMakeLists.txt#L139
But currently TEMP is set to a worker path build location that is removed on every run. WVlad will permanetly fix this by making THIRD_PARTY_DOWNLOAD_LOCATION settable in 10.6 and also increasing the timeout.
Until then, I manually copied
HeidiSQL_12.14_64_Portable.zipon the system and user TEMP location on the windows packages host, and will remove the TEMP env variable from the configuration, letting the system / user variable take precedence.