Add Unit Tests for Tonal Extractor Algorithm#1403
Closed
cvf-bcn-gituser wants to merge 5 commits intoMTG:masterfrom
Closed
Add Unit Tests for Tonal Extractor Algorithm#1403cvf-bcn-gituser wants to merge 5 commits intoMTG:masterfrom
cvf-bcn-gituser wants to merge 5 commits intoMTG:masterfrom
Conversation
Contributor
Author
|
FYI: See above pull request @palonso , @dbogdanov , @ffont |
cvf-bcn-gituser
force-pushed
the
master
branch
from
51ed609 to
ab2d3e5
Compare
Contributor
Author
|
Closing this as I add change to PR #1496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Extractor folder contains unit tests for key, level, music, rhythm descriptors and tuning frequency. Until now the tonal extractor has had no unit tests.
The unit tests added use the same general "boiler plate" of assertion tests that are typical of an extractor (silent test, valid config, etc.) as well as some tests on real audio, with some variation on config parameters. There is scope for adding more output checks on the more complex outputs such as chords_histogram, chords_progression. etc.
The idea behind capturing reference values for "chord changes rate", "key strength" for given audio files, is to support future regression testing on algorithm optimization and also to provide values to compare with other libraries.