fix combine_by_coords#267
Merged
rabernat merged 3 commits intoMITgcm:masterfrom May 28, 2021
Merged
Conversation
Contributor
Author
|
I think the tests fail due to maintainance of the ecco portal (#266). Unrelated to this PR. |
Member
|
Fantastic! Thanks so much @AaronDavidSchneider! |
Member
|
When I look at the test logs, I still see failing calls to Any idea what is going on there? |
Contributor
Author
|
Oh 😧 |
Contributor
Author
Member
I think we can live with this for now. |
fraserwg
pushed a commit
to fraserwg/xmitgcm
that referenced
this pull request
Nov 23, 2021
* fix combine_by_coords * change to new only for versions newer than previous xarray version * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
combine_by_coorscall to fix_swap_dims.Closes #265