fix: deduplicate photos in tag album listings#4328
Open
Conversation
Agent-Logs-Url: https://github.com/LycheeOrg/Lychee/sessions/263462c1-aa7c-43a2-8b7a-d39a29bccd71 Co-authored-by: ildyria <627094+ildyria@users.noreply.github.com>
Agent-Logs-Url: https://github.com/LycheeOrg/Lychee/sessions/263462c1-aa7c-43a2-8b7a-d39a29bccd71 Co-authored-by: ildyria <627094+ildyria@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tag album photo listing returning duplicate entries
fix: deduplicate photos in tag album listings
Apr 29, 2026
ildyria
approved these changes
Apr 29, 2026
Agent-Logs-Url: https://github.com/LycheeOrg/Lychee/sessions/2bcb1a88-be7d-4d83-a3f9-935c031e33ae Co-authored-by: ildyria <627094+ildyria@users.noreply.github.com>
Agent-Logs-Url: https://github.com/LycheeOrg/Lychee/sessions/2bcb1a88-be7d-4d83-a3f9-935c031e33ae Co-authored-by: ildyria <627094+ildyria@users.noreply.github.com>
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECT DISTINCT … ORDER BY COALESCE(…)crashes on PostgreSQL because raw ORDER BY expressions must literally appear in the SELECT list when using DISTINCT->distinct()with awhereIn('photos.id', $ids_query)approach: access-control JOINs stay inside a subquery that selectsphotos.id; outer relation query has no JOINs, no DISTINCT, no ORDER BY restrictionaddEagerConstraintsuse App\Models\Builders\PhotoBuilderimport, drop FQCN