Skip to content

Fixes for searchDialog, RegexHelperDialog, exception logging #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndisGrossteins wants to merge 6 commits into
base: Development
Choose a base branch
from
Open

Fixes for searchDialog, RegexHelperDialog, exception logging #477

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2cd9cc2
Fix text Regex Helper button
AndisGrossteins Oct 2, 2025
ee521cc
Fix exception in RegexHelperDialog
AndisGrossteins Oct 2, 2025
79d59d9
Log actual exception instead of ThreapdExceptionEventArgs or Unhandle…
AndisGrossteins Oct 2, 2025
0bacf4e
Reduce excessive log messages from PluginRegistry
AndisGrossteins Oct 2, 2025
4a3f5ac
Replace buttonRegexHelper with linkLabelRegexHelper
AndisGrossteins Oct 2, 2025
95bf3b0
Revert "Log actual exception instead of ThreapdExceptionEventArgs or …
AndisGrossteins Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/LogExpert.UI/Dialogs/RegexHelperDialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ private void OnCaseSensitiveCheckBoxCheckedChanged (object sender, EventArgs e)
private void OnButtonOkClick (object sender, EventArgs e)
{
var text = comboBoxRegex.Text;
comboBoxRegex.Items.Remove(text);
comboBoxRegex.Items.Insert(0, text);
_ = _expressionHistoryList.Remove(text);
_expressionHistoryList.Insert(0, text);

text = comboBoxTestText.Text;
comboBoxTestText.Items.Remove(text);
comboBoxTestText.Items.Insert(0, text);
_ = _testtextHistoryList.Remove(text);
_testtextHistoryList.Insert(0, text);

if (comboBoxRegex.Items.Count > MAX_HISTORY)
{
Expand Down
Loading
Loading