Skip to content

Add getters to Renderer and Preprocessor#19

Merged
LioQing merged 1 commit intomasterfrom
add-getters-in-preprocessor-and-renderer
Mar 26, 2026
Merged

Add getters to Renderer and Preprocessor#19
LioQing merged 1 commit intomasterfrom
add-getters-in-preprocessor-and-renderer

Conversation

@LioQing
Copy link
Copy Markdown
Owner

@LioQing LioQing commented Mar 26, 2026

  • Added bind_group_layout, pre_bundle, bundle, post_bundle, and bind_group getters in Preprocessor
  • Added bind_group_layout, pipeline, and bind_group getters in Renderer
  • Remove warning for active development, we're starting to slow down new feature additions

Close #7

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the public API surface of the viewer’s rendering components by exposing internal WGPU resources via accessor methods, making it easier for downstream users to integrate/customize pipelines without re-plumbing internals.

Changes:

  • Added getters on Renderer for bind_group_layout, pipeline, and bind_group.
  • Added getters on Preprocessor for bind_group_layout, pre_bundle, bundle, post_bundle, and bind_group.
  • Updated project docs/artifacts (changelog entry, README warning removal, regenerated coverage report).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/renderer.rs Adds public accessors for renderer bind group layout, pipeline, and bind group.
src/preprocessor.rs Adds public accessors for bind group layout, compute bundles, and bind group.
coverage/lcov.info Regenerated coverage output reflecting newly added getter functions.
README.md Removes the “breaking changes” warning block from the overview section.
CHANGELOG.md Adds a “Next release” entry documenting the new getters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/preprocessor.rs
Comment thread README.md
Comment thread src/preprocessor.rs
@LioQing LioQing added this to the v0.7.0 milestone Mar 26, 2026
@LioQing LioQing merged commit 58cb420 into master Mar 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow getting the render or compute pipeline from a pipeline wrapper

2 participants