Add getters to Renderer and Preprocessor#19
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the public API surface of the viewer’s rendering components by exposing internal WGPU resources via accessor methods, making it easier for downstream users to integrate/customize pipelines without re-plumbing internals.
Changes:
- Added getters on
Rendererforbind_group_layout,pipeline, andbind_group. - Added getters on
Preprocessorforbind_group_layout,pre_bundle,bundle,post_bundle, andbind_group. - Updated project docs/artifacts (changelog entry, README warning removal, regenerated coverage report).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/renderer.rs |
Adds public accessors for renderer bind group layout, pipeline, and bind group. |
src/preprocessor.rs |
Adds public accessors for bind group layout, compute bundles, and bind group. |
coverage/lcov.info |
Regenerated coverage output reflecting newly added getter functions. |
README.md |
Removes the “breaking changes” warning block from the overview section. |
CHANGELOG.md |
Adds a “Next release” entry documenting the new getters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bind_group_layout,pre_bundle,bundle,post_bundle, andbind_groupgetters inPreprocessorbind_group_layout,pipeline, andbind_groupgetters inRendererClose #7