Fix axis aligned gaussian causing NaN in shader#18
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical rendering bug where axis-aligned Gaussian positions caused NaN values in the shader during eigenvector normalization. The issue occurred when the 2D covariance matrix had zero off-diagonal terms and equal eigenvalues, resulting in a zero-length eigenvector that produced NaN when normalized.
Changes:
- Added zero-vector check before normalization in
cov2d_axesfunction to prevent NaN values - Updated coverage data (auto-generated)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shader/utils.wesl | Fixed NaN bug by using select to provide fallback direction when eigenvector is zero |
| coverage/lcov.info | Auto-generated code coverage data update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally fixed this annoying issue, it is caused by axis aligned Gaussian position (which is why the coverage/model.ply did not have this problem, because the Gaussian positions are not axis aligned), causing the eigenvector to be 0, 0, which gave an NaN when normalizing
Closes #8