Add Nextcloud 30 & 31 support#40
Add Nextcloud 30 & 31 support#40JonathanTreffler wants to merge 5 commits intoLibreCodeCoop:mainfrom
Conversation
Signed-off-by: Jonathan Treffler <jonathan.treffler@verdigado.com>
Signed-off-by: Jonathan Treffler <jonathan.treffler@verdigado.com>
|
(Added DCO in force-push) |
|
I have so far tested on NC 31 with no reason to doubt it would run on NC 30, but I will also test that later. |
Signed-off-by: Jonathan Treffler <jonathan.treffler@verdigado.com>
|
Look the failed checks. |
Signed-off-by: Jonathan Treffler <jonathan.treffler@verdigado.com>
| <repository type="git">https://github.com/librecodecoop/l10n_override</repository> | ||
| <dependencies> | ||
| <nextcloud min-version="28" max-version="28"/> | ||
| <nextcloud min-version="30" max-version="31"/> |
There was a problem hiding this comment.
Also will be necessary bump the version:
<version>2.0.0</version>Considering that is to be compatible with a newest version of Nextcloud server and considering the Nextcloud server as a framework, we can talk that it's should be a major increment.
What's you think about this? Maybe could be 3.0.0
There was a problem hiding this comment.
As there are no breaking changes to public interfaces per Semantic Versioning the correct version would be 2.1.0, but I personally would also be OK with 3.0.0, if you prefer that
| <repository type="git">https://github.com/librecodecoop/l10n_override</repository> | ||
| <dependencies> | ||
| <nextcloud min-version="28" max-version="28"/> | ||
| <nextcloud min-version="30" max-version="31"/> |
There was a problem hiding this comment.
Another point....
I know that could be a bit complex to make backports but we can set the min and max versionto 32 and after this, send the backport to a branch stable31.
We also can drop Nextcloud 30 because the official support by server will finish into September as we can see here: https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule
There was a problem hiding this comment.
Ah, I just realized I got the PR title wrong. NC 32 is not even out yet, i meant 30 and 31. And AFAIK apps should not mark themselves compatible with a version until that version is at least very close to a release.
There was a problem hiding this comment.
Is there any upside to going the backport way ?
I think normally this would be done when code changes to the app are needed between the two versions, so features can be backported to the old branch too.
Since this is only compatibility changes, no feature changes and no code changes between the versions are needed I think this approach would be simpler:
Releasing one version which covers both 30 and 31 and just drop NC 30 with any next release after September, when it is no longer supported.
Signed-off-by: Jonathan Treffler <jonathan.treffler@verdigado.com>
|
@vitormattos Could you please take a look at the updateAllLanguages function ? Before I changed it that function called $this->update() with 3 parameters, even though it only takes two. So I removed the parameter, whose name did not match by name. |
☑️ Resolves
This replaces the old removed NC systems (old event system) with their modern equivalents.
I also refactored any code that uses exec() as this command is forbidden and disabled in the environment I want this app to run it and not needed, this can all be done with easy native PHP.
🚧 Tasks
🏁 Checklist