LibWeb: Make WebIDL::invoke_callback() report exceptions in various places#2739
Merged
tcl3 merged 7 commits intoLadybirdBrowser:masterfrom Dec 19, 2024
Merged
Conversation
tcl3
force-pushed
the
libweb_error_reporting_fixes
branch
from
be2daab to
136ff15
Compare
tcl3
force-pushed
the
libweb_error_reporting_fixes
branch
from
136ff15 to
f597e18
Compare
tcl3
changed the title
run_timer_initialization_steps to the latest specWebIDL::invoke_callback() report exceptions in various places
Member
Author
|
My latest push uses the correct default exception behavior, which prevents a few Streams related crashes that were previously occurring. |
tcl3
force-pushed
the
libweb_error_reporting_fixes
branch
from
f597e18 to
ef38657
Compare
shannonbooth
reviewed
Dec 5, 2024
tcl3
force-pushed
the
libweb_error_reporting_fixes
branch
from
ef38657 to
f627338
Compare
`WebIDL::invoke_callback()` now takes an `exception_behavior` parameter, which can be set to `report` to report an exception before returning. Setting `exception_behavior` to `rethrow` retains the previous behavior.
This fixes a number of WPT tests, which expect an error to be reported if an exception is thrown in the timer callback.
tcl3
force-pushed
the
libweb_error_reporting_fixes
branch
from
f627338 to
831934b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a number of WPT tests, which expect an error to be reported if an exception is thrown in the timer callback.
Seven tests related to exception reporting, which were previously failing have been imported.