Skip to content

Specify some ogg encoder options#286

Open
RblSb wants to merge 2 commits intoKode:mainfrom
RblSb:stricter-ogg
Open

Specify some ogg encoder options#286
RblSb wants to merge 2 commits intoKode:mainfrom
RblSb:stricter-ogg

Conversation

@RblSb
Copy link
Copy Markdown
Contributor

@RblSb RblSb commented Apr 12, 2026

I'm not sure if {ffmpeg_ogg_options} is preferred way to specify this, instead of just adding these args in main directly. I refactored options extraction part a bit into a more functional style, i hope it looks a bit better.

And maybe we also need to specify output sampling rate? I just don't get if stb vorbis wants 44100, 48000, or it doesn't matter and can be custom.

  • Also updated to es2019 to access array.flat method

@RobDangerous
Copy link
Copy Markdown
Member

Sampling rate shouldn't matter. Ideally input == output but the output sampling rate is different on different systems.
Can't we just always set those ogg options for ffmpeg?

@RblSb
Copy link
Copy Markdown
Contributor Author

RblSb commented Apr 29, 2026

If you think parts.map() refactoring is not better than double for, i can reopen this PR as one line options.ogg args change instead. I just got confused by for (arg in args) and decided to rewrite that block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants