Merged
Conversation
…uth, and file (#20480)
…308) Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Brendan Allan <git@brendonovich.dev> Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
…(#20367) Co-authored-by: JosXa <info@josxa.dev> Co-authored-by: Luke Parker <10430890+Hona@users.noreply.github.com>
…global key events (#20205)
…ls from github models endpoint (falls back to models.dev) (#20533)
Resolve merge conflicts across e2e tests, UI components, and core packages. Clean up conflict markers in test specs by adopting the upstream `project` fixture pattern over the legacy `withProject` approach. Alphabetically sort package.json dependencies, apply consistent code formatting across i18n files, flag declarations, and TSX components. Update internal API calls to use current signatures (Permission.defaultLayer, MessageV2.parts, Git.run). Key changes: - Remove Windows-specific test.skip guards and conflict markers - Replace deprecated `git` util import with `Git.run` in worktree-family - Drop unused SDK type import from share-next - Add lib entries to kilo-gateway and kilo-telemetry tsconfigs - Regenerate models-snapshot.js and SDK types with reordered events - Fix SDK openapi.json code sample to reference @kilocode/sdk - Add onCleanup import to popover component
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| ...extraEnv, | ||
| } | ||
| const shell = process.platform === "win32" ? null : getUserShell() | ||
| const envs = shell ? mergeShellEnv(loadShellEnv(shell), env) : env |
Contributor
There was a problem hiding this comment.
WARNING: Shell env probing blocks the Electron main process on every command spawn
spawnCommand() is used for normal desktop CLI launches like serve() and debug config(), but this new loadShellEnv(shell) call runs synchronously and can spend up to 5 seconds inside spawnSync(..., timeout: 5000). On shells with slow or interactive startup files, that freezes the main process every time a command starts. Caching the probed env once, or moving the probe off the hot path, avoids turning shell startup latency into UI stalls.
Contributor
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (19 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.4-20260305 · 1,001,757 tokens |
Replace upstream opencode ASCII art with Kilo-branded wordmark in the CLI startup banner.
…l locales Introduce new localized strings for git/branch change titles and diff file list controls (changed, showAll, showLess, more) in 18 language files to support the updated session review UI.
… popup selector Align boolean expression continuation indent in isCompletionResult and reformat generic type constraint in PopupSelectorProps interface to follow consistent code style conventions.
…names Add GitHub Copilot API endpoint reference, update file paths to reflect github-copilot plugin directory restructure and tui config migration rename, and remove stale bun issue link references.
Add api.githubcopilot.com to the exclude patterns in the extraction script and regenerate source-links.md, dropping the now-filtered entry and updating the unique URL count from 79 to 78.
catrielmuller
approved these changes
Apr 14, 2026
.github/workflows/test.yml
Outdated
|
|
||
| permissions: | ||
| contents: read | ||
| # checks: write // kilocode_change |
Contributor
There was a problem hiding this comment.
WARNING: Removing checks: write disables the JUnit check report
mikepenz/action-junit-report@v6 creates or updates a GitHub check run by default, and its own action metadata/README explicitly requires checks: write unless you switch it to annotate_only. With this permission commented out, the Publish unit reports step can no longer publish the unit test check for PRs, so test results stop surfacing in the workflow checks.
marius-kilocode
added a commit
that referenced
this pull request
Apr 14, 2026
After the Effect migration in #8870, provider state is cached via InstanceState/ScopedCache. The hasKey check that determines which models are available ran once at init and was never re-evaluated. When auth changed (login, logout, org switch), only ModelCache was cleared but the provider state retained the stale hasKey decision, causing authenticated users to be stuck on the free model.
marius-kilocode
added a commit
that referenced
this pull request
Apr 14, 2026
* fix(cli): invalidate provider state after auth changes After the Effect migration in #8870, provider state is cached via InstanceState/ScopedCache. The hasKey check that determines which models are available ran once at init and was never re-evaluated. When auth changed (login, logout, org switch), only ModelCache was cleared but the provider state retained the stale hasKey decision, causing authenticated users to be stuck on the free model. * chore: add changeset * fix(gateway): scope disposeAll to KiloRoutesDeps, not ImportDeps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core
limit.inputoverrides.TUI
Desktop
SDK
Tool.define()tools from wrappingexecutemultiple times.Extensions