fix(cli): prioritize kilo config over opencode config#8781
Open
aravhawk wants to merge 1 commit intoKilo-Org:mainfrom
Open
fix(cli): prioritize kilo config over opencode config#8781aravhawk wants to merge 1 commit intoKilo-Org:mainfrom
aravhawk wants to merge 1 commit intoKilo-Org:mainfrom
Conversation
Load opencode config files before kilo config files so kilo.json and kilo.jsonc remain the authoritative override layer for both global and project config resolution. Add regression coverage for project, local .kilo, and global config precedence to guard the merge order. Fixes Kilo-Org#7621
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)No inline-commentable issues; the remaining issue is outside the diff. Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Fix these issues in Kilo Cloud Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 1,010,837 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix config merge precedence so
kilo.json/kilo.jsonccorrectly overrideopencode.json/opencode.jsoncin all CLI config loading paths.Root cause
The CLI loaded Kilo config files before Opencode config files in three places:
.kilo/Because later merges win, that let
opencode.*overridekilo.*, which is backwards for Kilo CLI.Changes
opencode.json{,c}beforekilo.json{,c}for project config resolutionopencode.json{,c}beforekilo.json{,c}for local config directory resolutionopencode.json{,c}beforekilo.json{,c}for global config resolution.kilo, and global precedenceValidation
git push -u origin codex/fix-kilo-config-priority-7621bun turbo typecheckbun --evalrepro from a temp repo confirmedkilo.jsonnow wins whileopencode.jsonstill provides fallback fieldsbun test test/config/config.test.tsFixes #7621