Fix header overlap issue on iOS Server Selection screen#6944
Open
Parsh wants to merge 1 commit into
Open
Conversation
…sing SafeAreaView and dismissing keyboard on tab switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a persistent UI bug on iOS where the Server Selection screen header could overlap the status bar after switching tabs. The fix ensures robust safe-area handling and resets scroll/keyboard state during tab switches. The changes are scoped to
ScreenWrapper.tsxandNodeSelection.tsx, and do not affect Android or other screens.iOS Server Selection layout and safe-area fixes:
src/components/ScreenWrapper.tsx: Replaces the iOS-specific manual padding anduseSafeAreaInsets()logic with a unifiedSafeAreaViewapproach for both platforms. This ensures the header and content always respect the safe-area insets natively, eliminating timing bugs from the JS hook. [1] [2]src/screens/AppSettings/Node/NodeSelection.tsx: Adds logic to dismiss the keyboard and reset theScrollViewposition to the top whenever the user switches tabs, preventing layout glitches and stale scroll offsets. [1] [2] [3]Specification and documentation updates:
openspec/specs/server-selection-layout/spec.md,openspec/changes/archive/2026-05-08-fix-server-selection-header-overlap/specs/server-selection-layout/spec.md: Adds and updates requirements to ensure status-bar clearance and scroll reset on tab switches for the Server Selection screen on iOS. [1] [2]openspec/changes/archive/2026-05-08-fix-server-selection-header-overlap/design.md,openspec/changes/archive/2026-05-08-fix-server-selection-header-overlap/proposal.md: Documents the context, decisions, and impact of the fix, including rationale for the approach and explicit non-goals. [1] [2]openspec/changes/archive/2026-05-08-fix-server-selection-header-overlap/tasks.md: Tracks implementation tasks and verification steps for the fix..vscode/settings.json: Adds terminal auto-approve settings formkdirandmvcommands (minor tooling update).openspec/changes/archive/2026-05-08-fix-server-selection-header-overlap/.openspec.yaml: Adds metadata for the spec-driven change.