Skip to content

fix(hooks): validate statusLine against schema, not truthy #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d123d wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix(hooks): validate statusLine against schema, not truthy #209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion hooks/caveman-activate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,12 @@ try {
let hasStatusline = false;
if (fs.existsSync(settingsPath)) {
const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
if (settings.statusLine) {
// Validate against the actual statusLine schema rather than a generic
// truthy check. A plain `if (settings.statusLine)` passes on strings,
// numbers, arrays, and partial/malformed objects — all of which suppress
// the nudge even though no working statusline is configured.
const sl = settings && settings.statusLine;
if (sl && sl.type === 'command' && typeof sl.command === 'string' && sl.command.length > 0) {
hasStatusline = true;
}
}
Expand Down