fix: read defaultLevel from pluginConfigs in settings.json#192
Open
gian-bytecode wants to merge 1 commit intoJuliusBrussee:mainfrom
Open
fix: read defaultLevel from pluginConfigs in settings.json#192gian-bytecode wants to merge 1 commit intoJuliusBrussee:mainfrom
gian-bytecode wants to merge 1 commit intoJuliusBrussee:mainfrom
Conversation
getDefaultMode() skipped pluginConfigs.'caveman@caveman'.options.defaultLevel entirely, falling back to hardcoded 'full'. Users had to /caveman ultra every session despite configuring defaultLevel in settings.json. Resolution order is now: 1. CAVEMAN_DEFAULT_MODE env var 2. pluginConfigs.'caveman@caveman'.options.defaultLevel in settings.json 3. ~/.config/caveman/config.json defaultMode 4. Hardcoded 'full' Fixes JuliusBrussee#189
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getDefaultMode() skipped pluginConfigs.'caveman@caveman'.options.defaultLevel entirely, falling back to hardcoded 'full'. Users had to /caveman ultra every session despite configuring defaultLevel in settings.json.
Resolution order is now:
Fixes #189