Skip to content

feat: package dependency <package-name> cmd to list dependencies#23

Open
thelonewolf1603 wants to merge 24 commits intomainfrom
nd/package-dependency-cmd
Open

feat: package dependency <package-name> cmd to list dependencies#23
thelonewolf1603 wants to merge 24 commits intomainfrom
nd/package-dependency-cmd

Conversation

@thelonewolf1603
Copy link
Contributor

CLAUDE.md Outdated
- **Display limits**:
- Default: Shows up to 10 direct dependencies
- With `--indirect`: Shows up to 10 direct and 50 indirect dependencies
- With `--all`: Shows all dependencies without limits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"all" means "direct" could be confusing for the users?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate, didnt get what you mean

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was bit confused about "all" which I thought implies "direct" and "indirect" but here it implies there is no pagination? Can we call it "--no-limit"? Maybe we could have a larger discussion on this on a call

},
}

var packageInfoCmd = &cobra.Command{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be part of this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so these branches i have checked out from previous prs, which will be removed once those are merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

README.md Outdated

- **Authentication**: OAuth2 device flow authentication with JWT token handling
- **Dataset Management**: List, download, upload, and check status of datasets
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unresolved conflict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@@ -0,0 +1,27 @@
query FilteredPackagesCounts(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes supposed to be part of this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, but it was last of the package prs and the query needed to be split, so i added it here only. if you want i can make a separate one

Copy link
Member

@vdayanand vdayanand Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if it was a separate one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, can you signoff this PR first then #31

Remove package_search_count.gql and restore the combined
package_search_with_count.gql approach. The split of search and count
into separate GraphQL queries will be handled in a dedicated PR.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants