IJPL-173071 JSON Schema: fix Draft 2020-12 meta-schema validation for const keyword#3438
Open
deinspanjer wants to merge 1 commit intoJetBrains:masterfrom
Open
Conversation
… const keyword Correct metadata inheritance priority in Draft 2020-12 to prevent root meta-schema constraints from incorrectly leaking into boolean schema definitions. Key changes: - Corrected parameter order in InheritedJsonSchemaObjectView.kt helper functions to prioritize base schema over context. - Added a short-circuit in JsonSchemaAnnotatorChecker.java to skip type validation for constant schemas. - Ensured ConstantSchemaValidation takes precedence in JsonSchema202012Strategy.kt and jsonSchemaValidationsCollector.kt.
Author
|
I also did a git pickaxe with the help of Junie to make sure the order of the parameters wasn't flipped intentionally: I have performed a git pickaxe (using both -S and -G flags) on InheritedJsonSchemaObjectView.kt to trace the history of those helper method calls.
Conclusion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct metadata inheritance priority in Draft 2020-12 to prevent root meta-schema constraints from incorrectly leaking into boolean schema definitions.
Key changes: