Add Deref and DerefMut derive for enums#485
Merged
tyranron merged 14 commits intoJelteF:masterfrom Jul 7, 2025
Merged
Conversation
Contributor
Author
|
The failed lints are unrelated. Fixed in #486. |
tyranron
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #388
Synopsis
Add
DerefandDerefMutderive for enums. Only works on a single field of each variant of the enum and as long as the field types are compatible.See added docs and tests for more usage examples.
Solution
Make sure each of the enum variants contains 1 and only 1 enabled field, then generate a
matchblock to extract the field. Checking if the field types are compatible are unnecessary since this case will fail compilation anyway.Checklist