fix: guard against undefined slice/map crashes in search actions

[octo-patch]

Fixes #964

Problem

TypeError: Cannot read properties of undefined (reading 'slice') occurs when:

1. LLM tool calls (via LiteLLM proxy or models that don't strictly conform to the JSON schema) return queries/urls as undefined
2. SearXNG returns a response without a results field (e.g. on error responses or unexpected formats), causing downstream .map() to crash

The webSearch, academicSearch, and socialSearch actions already had defensive Array.isArray() checks, but uploadsSearch and scrapeURL were missing them. The root-level searxng.ts also assumed data.results and data.suggestions were always present.

Solution

• Default queries to [] before .slice(0, 3) in uploadsSearch.ts and scrapeURL.ts
• Default SearXNG results and suggestions to [] at the source in searxng.ts, protecting all consumers

Testing

• Normal searches continue to work as before
• Malformed tool call arguments (undefined queries/urls) now return empty results instead of crashing
• SearXNG returning unexpected response shapes no longer causes unhandled rejections

---

Summary by cubic

Prevents TypeError crashes in search actions by defaulting undefined inputs and SearXNG fields to empty arrays (fixes #964). Malformed tool calls and error responses now return empty results instead of throwing.

• Bug Fixes
  • Default queries/urls to [] before .slice() in uploadsSearch and scrapeURL.
  • Default SearXNG results/suggestions to [] in searxng.ts.

^{Written for commit 68105d3. Summary will update on new commits.}

[cubic-dev-ai]

3 issues found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/lib/searxng.ts">

<violation number="1" location="src/lib/searxng.ts:55">
P2: `?? []` does not validate runtime response shape; non-array `results`/`suggestions` can still propagate and trigger downstream `.forEach`/`.map` crashes.</violation>
</file>

<file name="src/lib/agents/search/researcher/actions/scrapeURL.ts">

<violation number="1" location="src/lib/agents/search/researcher/actions/scrapeURL.ts:28">
P2: `?? []` avoids only null/undefined, but non-array `urls` values can still crash `.slice()`/`.map()` at runtime.</violation>
</file>

<file name="src/lib/agents/search/researcher/actions/uploadsSearch.ts">

<violation number="1" location="src/lib/agents/search/researcher/actions/uploadsSearch.ts:30">
P2: The nullish fallback is incomplete: `queries` is not validated as an array, so malformed non-array inputs can still crash or propagate wrong types.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: ?? [] does not validate runtime response shape; non-array results/suggestions can still propagate and trigger downstream .forEach/.map crashes.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/searxng.ts, line 55:

<comment>`?? []` does not validate runtime response shape; non-array `results`/`suggestions` can still propagate and trigger downstream `.forEach`/`.map` crashes.</comment>

<file context>
@@ -52,8 +52,8 @@ export const searchSearxng = async (
 
-    const results: SearxngSearchResult[] = data.results;
-    const suggestions: string[] = data.suggestions;
+    const results: SearxngSearchResult[] = data.results ?? [];
+    const suggestions: string[] = data.suggestions ?? [];
 
</file context>

[cubic-dev-ai]

P2: ?? [] avoids only null/undefined, but non-array urls values can still crash .slice()/.map() at runtime.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/agents/search/researcher/actions/scrapeURL.ts, line 28:

<comment>`?? []` avoids only null/undefined, but non-array `urls` values can still crash `.slice()`/`.map()` at runtime.</comment>

<file context>
@@ -25,7 +25,7 @@ const scrapeURLAction: ResearchAction<typeof schema> = {
   enabled: (_) => true,
   execute: async (params, additionalConfig) => {
-    params.urls = params.urls.slice(0, 3);
+    params.urls = (params.urls ?? []).slice(0, 3);
 
     let readingBlockId = crypto.randomUUID();
</file context>

Suggested change

	params.urls = (params.urls ?? []).slice(0, 3);
	const urls = Array.isArray(params.urls) ? params.urls : [];
	params.urls = urls.slice(0, 3);

[cubic-dev-ai]

P2: The nullish fallback is incomplete: queries is not validated as an array, so malformed non-array inputs can still crash or propagate wrong types.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/agents/search/researcher/actions/uploadsSearch.ts, line 30:

<comment>The nullish fallback is incomplete: `queries` is not validated as an array, so malformed non-array inputs can still crash or propagate wrong types.</comment>

<file context>
@@ -27,7 +27,7 @@ const uploadsSearchAction: ResearchAction<typeof schema> = {
   `,
   execute: async (input, additionalConfig) => {
-    input.queries = input.queries.slice(0, 3);
+    input.queries = (input.queries ?? []).slice(0, 3);
 
     const researchBlock = additionalConfig.session.getBlock(
</file context>

Suggested change

	input.queries = (input.queries ?? []).slice(0, 3);
	input.queries = Array.isArray(input.queries)
	? input.queries.slice(0, 3)
	: [];