Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
all:

clone-injective-indexer:
git clone https://github.com/InjectiveLabs/injective-indexer.git -b v1.17.16 --depth 1 --single-branch
git clone https://github.com/InjectiveLabs/injective-indexer.git -b v1.17.81 --depth 1 --single-branch

clone-injective-core:
git clone https://github.com/InjectiveLabs/injective-core.git -b v1.17.0 --depth 1 --single-branch
git clone https://github.com/InjectiveLabs/injective-core.git -b v1.18.0-alpha.3 --depth 1 --single-branch
Comment on lines 6 to +7
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

injective-core latest stable release version

💡 Result:

The latest stable release of injective-core (Docker image injectivelabs/injective-core) is v1.17.2. (github.com)

Citations:


🏁 Script executed:

# Check if there's any documentation in the repo about versioning strategy
find . -type f \( -name "*.md" -o -name "*.txt" \) | head -20 | xargs grep -l "injective-core\|version" 2>/dev/null | head -5

Repository: InjectiveLabs/sdk-go

Length of output: 184


🏁 Script executed:

# Check git history of the Makefile to see version progression
git log --oneline -p Makefile 2>/dev/null | grep -A 2 -B 2 "injective-core" | head -30

Repository: InjectiveLabs/sdk-go

Length of output: 2080


Confirm alpha version pinning—either wait for stable v1.18.0 or document pre-release status.

The clone target uses v1.18.0-alpha.3, a pre-release version. The latest stable release is v1.17.2. If this alpha pin is intentional to support an upcoming chain release, add a comment in the Makefile explaining the reasoning. Otherwise, consider waiting for a stable v1.18.0 release or pin to v1.17.2 if compatibility is not required.

🤖 Prompt for AI Agents
In `@Makefile` around lines 6 - 7, The Makefile target clone-injective-core
currently pins the git clone to pre-release branch v1.18.0-alpha.3; either
document this decision or pin to a stable release: update the
clone-injective-core target (the git clone ... -b ... flag) to use v1.17.2 if
you want stable compatibility, or add a clear comment above the target
explaining why v1.18.0-alpha.3 is required (e.g., network/feature dependency)
and note that it is a pre-release so reviewers/consumers are aware; make the
change directly in the Makefile around the clone-injective-core target and the
git clone -b argument.


copy-exchange-client: clone-injective-indexer
rm -rf exchange/*
Expand Down Expand Up @@ -104,8 +104,7 @@ copy-chain-types: clone-injective-core
cp injective-core/injective-chain/modules/oracle/types/oracle.go chain/oracle/types && \
cp injective-core/injective-chain/modules/oracle/types/params.go chain/oracle/types && \
cp injective-core/injective-chain/modules/oracle/types/proposal.go chain/oracle/types && \
cp injective-core/injective-chain/modules/oracle/types/stork_oracle.go chain/oracle/types && \
cp -r injective-core/injective-chain/modules/oracle/bandchain chain/oracle
cp injective-core/injective-chain/modules/oracle/types/stork_oracle.go chain/oracle/types
mkdir -p chain/peggy/types && \
cp injective-core/injective-chain/modules/peggy/types/*.pb.go chain/peggy/types && \
cp injective-core/injective-chain/modules/peggy/types/abi_json.go chain/peggy/types && \
Expand Down
139 changes: 137 additions & 2 deletions chain/evm/precompiles/bank/fixed_supply_bank_erc20.abigen.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion chain/evm/precompiles/bank/i_bank_module.abigen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

139 changes: 137 additions & 2 deletions chain/evm/precompiles/bank/mint_burn_bank_erc20.abigen.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion chain/evm/precompiles/exchange/i_exchange_module.abigen.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion chain/evm/precompiles/staking/i_staking_module.abigen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions chain/evm/types/events.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ package types
const (
EventTypeEthereumTx = TypeMsgEthereumTx
EventTypeBlockBloom = "block_bloom"
EventTypeTxLog = "tx_log"

AttributeKeyContractAddress = "contract"
AttributeKeyRecipient = "recipient"
Expand All @@ -13,7 +12,7 @@ const (
AttributeKeyTxIndex = "txIndex"
AttributeKeyTxGasUsed = "txGasUsed"
AttributeKeyTxType = "txType"
AttributeKeyTxLog = "txLog"

// tx failed in eth vm execution
AttributeKeyEthereumTxFailed = "ethereumTxFailed"
AttributeValueCategory = ModuleName
Expand Down
Loading