Skip to content

chore: add logout to create org modal#6103

Open
sheensantoscapadngan wants to merge 3 commits intomainfrom
chore/add-logout-to-creater-org-modal
Open

chore: add logout to create org modal#6103
sheensantoscapadngan wants to merge 3 commits intomainfrom
chore/add-logout-to-creater-org-modal

Conversation

@sheensantoscapadngan
Copy link
Copy Markdown
Member

Context

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@sheensantoscapadngan sheensantoscapadngan changed the title chore: add logoujt to create org modal chore: add logout to create org modal Apr 20, 2026
@maidul98
Copy link
Copy Markdown
Collaborator

maidul98 commented Apr 20, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f90b7a2ff

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

<button
type="button"
className="text-sm text-mineshaft-400 underline-offset-4 hover:text-mineshaft-200 hover:underline"
onClick={() => logout.mutate()}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Redirect user to login after logout action

Clicking the new "Log out" control only calls logout.mutate() and never navigates away, so in the NoOrgPage flow (CreateOrgModal rendered without onClose) the user can remain on /_authenticate/organizations/none even after session state is cleared. Because auth checks for this route run in beforeLoad on navigation, the page does not automatically re-run access control here; this leaves users on an authenticated route with a logged-out session until a manual refresh/navigation happens. Align this path with other logout handlers by awaiting logout and explicitly routing to /login.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants